Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] Fix FormDataCollector#20762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 2 commits intosymfony:3.2fromnicolas-grekas:fix-form-data-collector
Dec 6, 2016

Conversation

nicolas-grekas
Copy link
Member

QA
Branch?3.2
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#20698
LicenseMIT
Doc PR-

Alternative to#20707

@stof
Copy link
Member

stof commentedDec 5, 2016

Can you add test covering the bug to prevent regressions ?

@nicolas-grekas
Copy link
MemberAuthor

No, I can't... This code is a maze...

ogizanagi, chalasr, and Padam87 reacted with laugh emoji

@stof
Copy link
Member

stof commentedDec 5, 2016•
edited by nicolas-grekas
Loading

Well, you said you had a reproducer. Couldn't it be used as a test ?

@nicolas-grekas
Copy link
MemberAuthor

nicolas-grekas commentedDec 5, 2016•
edited
Loading

It's a functional test with master + sub requests + profiler enabled. ie. a heavy stack...

@Padam87Padam87 mentioned this pull requestDec 5, 2016
@Padam87
Copy link
Contributor

I can confirm that the patch works.

Padam87 added a commit to Padam87/symfony that referenced this pull requestDec 5, 2016
@Padam87
Copy link
Contributor

I've added a failing test, which is fixed by this patch

@stof
Copy link
Member

stof commentedDec 6, 2016

👍

@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commit50400c4 intosymfony:3.2Dec 6, 2016
fabpot added a commit that referenced this pull requestDec 6, 2016
This PR was merged into the 3.2 branch.Discussion----------[Form] Fix FormDataCollector| Q             | A| ------------- | ---| Branch?       | 3.2| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#20698| License       | MIT| Doc PR        | -Alternative to#20707Commits-------50400c4 [Form] Add failing test for data collector bug164a20c [Form] Fix FormDataCollector
@nicolas-grekasnicolas-grekas deleted the fix-form-data-collector branchDecember 9, 2016 10:57
@fabpotfabpot mentioned this pull requestDec 13, 2016
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@nicolas-grekas@stof@Padam87@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp