Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Validator] add class name to the cache key#20745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
28454d0 to122c01dCompare
dunglas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you also add a test with a relation between ChildA and ChilB?
| { | ||
| /** | ||
| * @Assert\Valid | ||
| * @Assert\NotBlank |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You should use another assertion to be sure that there is no collision.
dunglas commentedDec 8, 2016
👍 |
| private$internal; | ||
| public$data ='Overridden data'; | ||
| public$initialized =false; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this line should be kept
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
nicolas-grekas commentedDec 8, 2016
Thank you@Simperfit. |
This PR was squashed before being merged into the 3.1 branch (closes#20745).Discussion----------[Validator] add class name to the cache key| Q | A| ------------- | ---| Branch? | 3.1| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#20685| License | MIT| Doc PR |Adding the class name to the cache key to avoid collisionCommits-------1681fc9 [Validator] add class name to the cache key
Uh oh!
There was an error while loading.Please reload this page.
Adding the class name to the cache key to avoid collision