Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[WebProfilerBundle] Display multiple HTTP headers in WDT#20599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedNov 22, 2016
FYI, I moved the logic in the request collector:https://github.com/symfony/symfony/pull/20595/files#diff-e8f5b14fbfbbeac60fc9f3abe310c3b0R128 |
ro0NL commentedNov 22, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Updated, rebasing should be easy now. |
fabpot commentedDec 19, 2016
Thank you@ro0NL. |
…ro0NL)This PR was merged into the 2.7 branch.Discussion----------[WebProfilerBundle] Display multiple HTTP headers in WDT| Q | A| ------------- | ---| Branch? | 2.7 (partially in 3.2 already)| Bug fix? | yes| New feature? | no| BC breaks? | no-ish| Deprecations? | no| Tests pass? | yes| Fixed tickets | [#20595 (comment)](#20595 (comment))| License | MIT| Doc PR | reference to the documentation PR, if anyBackport of#20595 for 2.7, that includes a fix for displaying multiple HTTP headers in the WDT.//cc@nicolas-grekas this should cover 2.7 - 3.1 right?Commits-------257a856 [WebProfilerBundle] Display multiple HTTP headers in WDT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@fabpot sorry for the inconvenience :) but im not sure upstream merges went as expected..?
edit: is this about 3.1 almost being EOM?
| if (count($cookies) >0) { | ||
| $responseHeaders['Set-Cookie'] =$cookies; | ||
| $responseHeaders['set-cookie'][] = (string)$cookie; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| $this->data[$key] =$value; | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Above should apply to 3.1 as well.
In master this is already applied due#20595.
| publicfunctiongetRequestHeaders() | ||
| { | ||
| returnnewHeaderBag($this->data['request_headers']); | ||
| returnnewParameterBag($this->data['request_headers']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Same, should be applied to 3.1
| publicfunctiongetResponseHeaders() | ||
| { | ||
| returnnewResponseHeaderBag($this->data['response_headers']); | ||
| returnnewParameterBag($this->data['response_headers']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Same, should be applied to 3.1
| } | ||
| return$cookie; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Same, should be applied to 3.1
and the remaining tests of course.
This PR was merged into the 3.1 branch.Discussion----------[HttpKernel] Continuation of#20599 for 3.1| Q | A| ------------- | ---| Branch? | 3.1 only| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | symfony/symfony-docs#... <!--highly recommended for new features-->#20599 is only merged up to 2.8.. not sure if 3.1 is already EOM?Commits-------c245f87 [HttpKernel] Continuation of#20599 for 3.1
* 3.1: [HttpKernel] Continuation of#20599 for 3.1
* 3.2: [HttpKernel] Continuation of#20599 for 3.1 Add missing upgrade path for Request::isMethodSafe() deprecation
Uh oh!
There was an error while loading.Please reload this page.
Backport of#20595 for 2.7, that includes a fix for displaying multiple HTTP headers in the WDT.
//cc@nicolas-grekas this should cover 2.7 - 3.1 right?