Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Allowed symlinks when searching for translation, searialization and validation files#20547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@tifabien
Copy link
Contributor

@tifabientifabien commentedNov 17, 2016•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

When we have a symlink folder in app/Resources/translations, files inside this symlink are not handled.

@xabbuh
Copy link
Member

If we want to allow symlinks here, we should do the same for the validation files. What do you think?

@tifabien
Copy link
ContributorAuthor

I agree. What about serialization files?

@tifabien
Copy link
ContributorAuthor

I added the followLinks on both serialization and validation files

@tifabien
Copy link
ContributorAuthor

@xabbuh Is it OK for you? Note that I don't understand why the travis build is in error for PHP5.3.
Any idea?

@nicolas-grekas
Copy link
Member

Looks like a new behavior, thus new feature to me. Am I wrong?

@xabbuh
Copy link
Member

Agreed, to treat this as a new features.

Besides that 👍 from me.

@tifabien
Copy link
ContributorAuthor

If you consider this as a new feature, do I need to rebase my branch on top of master or 3.2(as it's not released yet)?

@javiereguiluz
Copy link
Member

New features should now go tomaster because3.2 entered its "code freeze" period.

@tifabientifabien changed the base branch from2.7 tomasterNovember 25, 2016 11:31
@tifabien
Copy link
ContributorAuthor

OK for me I changed the destination branch.

@tifabientifabien changed the title[FrameworkBundle] Fix Finder when searching for translation files with symlinks[FrameworkBundle] Allowed symlinks when searching for translation, searialization and validation filesNov 25, 2016
@nicolas-grekasnicolas-grekas added Feature and removed Bug labelsDec 6, 2016
@nicolas-grekasnicolas-grekas added this to the3.x milestoneDec 6, 2016
@nicolas-grekas
Copy link
Member

👍

@fabpot
Copy link
Member

Thank you@tifabien.

@fabpotfabpot closed thisJan 6, 2017
fabpot added a commit that referenced this pull requestJan 6, 2017
…translation, searialization and validation files (tifabien)This PR was squashed before being merged into the 3.3-dev branch (closes#20547).Discussion----------[FrameworkBundle] Allowed symlinks when searching for translation, searialization and validation files| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -When we have a symlink folder in app/Resources/translations, files inside this symlink are not handled.Commits-------4874e43 [FrameworkBundle] Allowed symlinks when searching for translation, searialization and validation files
@nicolas-grekasnicolas-grekas modified the milestones:3.x,3.3Mar 24, 2017
@fabpotfabpot mentioned this pull requestMay 1, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

6 participants

@tifabien@xabbuh@nicolas-grekas@javiereguiluz@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp