Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer] Remove AbstractObjectNormalizer::isAttributeToNormalize#20530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@dunglas
Copy link
Member

@dunglasdunglas commentedNov 15, 2016•
edited
Loading

QA
Branch?3.1
Bug fix?yes
New feature?no
BC breaks?unclear
Deprecations?no
Tests pass?yes
Fixed ticketsn/a
LicenseMIT
Doc PRn/a

I've introduced this method by error in#17113. It has been forgotten during a refactoring. It has always been unused, is not covered by our test suite and has never been documented.

Technically it's a BC break (because this is a protected method), but I think that it's better to remove it has it has never be intended to be used, it's just a miss. An alternative is to deprecate it and remove it in v4.

@fabpot
Copy link
Member

👍 to remove it as done by this PR.

@xabbuh
Copy link
Member

I would vote for deprecating the method to prevent unexpected BC breaks for users of this class.

@fabpot
Copy link
Member

@xabbuh Is it really worth it?

@xabbuh
Copy link
Member

Judging by the name of the method and given the fact that people will use theAbstractObjectNormalizer as the base class for their own normalizers, I fear that there will be users out there who call this method before doing actual normalisation work which would then break.

@fabpot
Copy link
Member

Ok, fair enough. Let's add a deprecation notice then.

@dunglas
Copy link
MemberAuthor

dunglas commentedNov 16, 2016•
edited
Loading

After a quick search, I wasn't able to find any public project using this method. Regarding the fact that it was introduced in 3.1 (only 6 months ago) and is useless, I really doubt than anybody has used it.

@ro0NL
Copy link
Contributor

ro0NL commentedNov 16, 2016•
edited
Loading

Maybe add achangelog upgrade note about the silent removal of this method. As it was forgotten before...

Imo. we can totally be pragmatic on left-over code from one minor to another. But it should be documented.

dunglas and tjaari reacted with thumbs up emoji

@nicolas-grekas
Copy link
Member

👍 on my side for an UPGRADE entry and no deprecation.

@nicolas-grekas
Copy link
Member

Thank you@dunglas.

nicolas-grekas added a commit that referenced this pull requestDec 8, 2016
…oNormalize (dunglas)This PR was squashed before being merged into the 3.1 branch (closes#20530).Discussion----------[Serializer] Remove AbstractObjectNormalizer::isAttributeToNormalize| Q             | A| ------------- | ---| Branch?       | 3.1| Bug fix?      | yes| New feature?  | no| BC breaks?    | unclear| Deprecations? | no| Tests pass?   | yes| Fixed tickets | n/a| License       | MIT| Doc PR        | n/aI've introduced this method by error in#17113. It has been forgotten during a refactoring. It has always been unused, is not covered by our test suite and has never been documented.Technically it's a BC break (because this is a protected method), but I think that it's better to remove it has it has never be intended to be used, it's just a miss. An alternative is to deprecate it and remove it in v4.Commits-------fea18aa [Serializer] Remove AbstractObjectNormalizer::isAttributeToNormalize
This was referencedDec 13, 2016
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

3.1

Development

Successfully merging this pull request may close these issues.

6 participants

@dunglas@fabpot@xabbuh@ro0NL@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp