Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Revert "bug #20184 [FrameworkBundle] Convert null prefix to an empty string in translation:update (chalasr)"#20433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
javiereguiluz commentedNov 7, 2016
👍 Status: reviewed |
stof commentedNov 7, 2016
👍 |
stof commentedNov 7, 2016
@javiereguiluz why adding the 3.2 milestone ? This targets the 2.7 branch, as this is where the buggy patch was merged |
javiereguiluz commentedNov 7, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@stof you are right. The idea of the "3.2" milestone is"PRs to be merged before the release of Symfony 3.2" and not"PRs to be merged exclusively for Symfony 3.2". It'd be sad to release 3.2.0 with well-known bugs that already have a solution and had to wait for 3.2.1. |
fabpot commentedNov 7, 2016
Thank you@chalasr. |
… to an empty string in translation:update (chalasr)" (chalasr)This PR was merged into the 2.7 branch.Discussion----------Revert "bug#20184 [FrameworkBundle] Convert null prefix to an empty string in translation:update (chalasr)"| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#20184 (comment)| License | MIT| Doc PR | n/aThis reverts commit3f650f8 because the fix is not valid.It is actually not possible to have an option with value optional given empty to be `empty` if this one has a default value. The default value will always be the one returned, see#20184 (comment) for details.Commits-------b2fa7c4 Revert "bug#20184 [FrameworkBundle] Convert null prefix to an empty string in translation:update (chalasr)"
This reverts commit3f650f8 because the fix is not valid.
It is actually not possible to have an option with value optional given empty to be
emptyif this one has a default value. The default value will always be the one returned, see#20184 (comment) for details.