NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Revert "feature #17608 [DependencyInjection] Autowiring: add setter injection support (dunglas)"#20384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

dunglas merged 1 commit intosymfony:masterfromnicolas-grekas:revert-17608

Nov 2, 2016

Merged

Revert "feature #17608 [DependencyInjection] Autowiring: add setter injection support (dunglas)"#20384

dunglas merged 1 commit intosymfony:masterfromnicolas-grekas:revert-17608

Nov 2, 2016

Conversation

Copy link

Member

nicolas-grekas commentedNov 2, 2016•
edited
Loading

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	-
License	MIT
Doc PR	-

This reverts commit7eab6b9, reversing
changes made to35f201f.

As discussed in#20167

Revert "featuresymfony#17608[DependencyInjection] Autowiring: add s…

bf91eda

…etter injection support (dunglas)"This reverts commit7eab6b9, reversingchanges made to35f201f.

carsonbot added Status: Needs Review DependencyInjection Feature BC Break Deprecation labels

Nov 2, 2016

nicolas-grekas removed the BC Break label

Nov 2, 2016

Copy link

Member

stof commentedNov 2, 2016

👍
We need some time to mature the setter autowiring, so let's delay it for 3.3

nicolas-grekas added Ready and removed Deprecation labels

Nov 2, 2016

Copy link

Member

dunglas commentedNov 2, 2016

👍

The fabbot error isn't related but should be fixed in another PR.

Copy link

Member

dunglas commentedNov 2, 2016

Thanks@nicolas-grekas.

dunglas merged commitbf91eda intosymfony:master

Nov 2, 2016

dunglas added a commit that referenced this pull request

Nov 2, 2016

minor#20384Revert "feature#17608[DependencyInjection] Autowiring:…

070e53a

… add setter injection support (dunglas)" (nicolas-grekas)This PR was merged into the 3.2-dev branch.Discussion----------Revert "feature#17608 [DependencyInjection] Autowiring: add setter injection support (dunglas)"| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -This reverts commit7eab6b9, reversingchanges made to35f201f.As discussed in#20167Commits-------bf91eda Revert "feature#17608 [DependencyInjection] Autowiring: add setter injection support (dunglas)"