Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Console] Fix empty COLUMNS/LINES env vars#20328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromnicolas-grekas:fix-putenv
Oct 27, 2016

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?3.2
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

Here is a python app that fails otherwise:

test.py:

importosint(os.environ.get('COLUMNS',80))

test.php:

<?phpputenv('COLUMNS=');passthru('python test.py');

result:

$ php test.phpTraceback (most recent call last): File "test.py", line 3, in <module>   int(os.environ.get('COLUMNS', 80))ValueError: invalid literal for int() with base 10: ''

@romainneutron
Copy link
Contributor

👍

@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commit8ad991e intosymfony:masterOct 27, 2016
fabpot added a commit that referenced this pull requestOct 27, 2016
This PR was merged into the 3.2-dev branch.Discussion----------[Console] Fix empty COLUMNS/LINES env vars| Q             | A| ------------- | ---| Branch?       | 3.2| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Here is a python app that fails otherwise:test.py:```pythonimport osint(os.environ.get('COLUMNS', 80))```test.php:```php<?phpputenv('COLUMNS=');passthru('python test.py');```result:```$ php test.phpTraceback (most recent call last): File "test.py", line 3, in <module>   int(os.environ.get('COLUMNS', 80))ValueError: invalid literal for int() with base 10: ''```Commits-------8ad991e [Console] Fix empty COLUMNS/LINES env vars
@nicolas-grekasnicolas-grekas deleted the fix-putenv branchOctober 27, 2016 16:32
@fabpotfabpot mentioned this pull requestNov 17, 2016
fabpot added a commit that referenced this pull requestApr 11, 2017
…ded) (duncan3dc)This PR was merged into the 3.2 branch.Discussion----------[Console] Allow terminal dimensions to be set to 0 (unbounded)| Q             | A| ------------- | ---| Branch?       | 3.2| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#21513| License       | MITA previous PR (#20328) changed the behavior of terminals with undefined widths from unbounded to 80 characters. And due to the way the existing code worked it become impossible to set a terminal to be unbounded again. This PR provides a way to restore the previous behavior:```phpputenv('COLUMNS=0');```Commits-------4c1b001 Allow terminal dimensions to be set to 0 (unbounded)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolas-grekas@romainneutron@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp