Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[VarDumper] Fix dumping Twig source in stack traces#20326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedOct 27, 2016
| Q | A |
|---|---|
| Branch? | 2.8 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #20320 |
| License | MIT |
| Doc PR | - |
| publicfunction__construct(Twig_Environment$env =null,$filename =null) | ||
| { | ||
| parent::__construct($env); | ||
| if (null !==$env) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
if ($env)
javiereguiluz commentedOct 27, 2016
I've tested this PR and the new output is quite different from the one reported in#20320. However, I think that this new output makes it more difficult to understand what's going on (and there are some design issues, such as the different font families applied to the output):
|
nicolas-grekas commentedOct 27, 2016
@javiereguiluz please open a new issue or a PR (esp. for the font issue, which is not intentional) |
fabpot commentedOct 27, 2016
Thank you@nicolas-grekas. |
…as-grekas)This PR was merged into the 2.8 branch.Discussion----------[VarDumper] Fix dumping Twig source in stack traces| Q | A| ------------- | ---| Branch? | 2.8| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#20320| License | MIT| Doc PR | -Commits-------f16d44d [VarDumper] Fix dumping Twig source in stack traces