Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[VarDumper] Fix ArgsStub#20265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
[VarDumper] Fix ArgsStub#20265
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
stof commentedOct 21, 2016
does it affect only 3.2 or should such bug fixes be applied to older branches too ? |
MemberAuthor
nicolas-grekas commentedOct 21, 2016
ArgsStub on 3.2 only |
20b7f9b to479baecCompare479baec to808c25eCompareMember
fabpot commentedOct 21, 2016
Thank you@nicolas-grekas. |
fabpot added a commit that referenced this pull requestOct 21, 2016
This PR was merged into the 3.2-dev branch.Discussion----------[VarDumper] Fix ArgsStub| Q | A| ------------- | ---| Branch? | 3.2| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Two bugs fixed here:- ArgsStub changing the value of arguments passed by reference- `class::function` used with off-by-one `args`Commits-------808c25e [VarDumper] Fix ArgsStub
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs fixed here:
class::functionused with off-by-oneargs