Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer] Support specifying format for DateTimeNormalizer::denormalize#20217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@teohhanhui
Copy link
Contributor

@teohhanhuiteohhanhui commentedOct 14, 2016•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsN/A
LicenseMIT
Doc PRsymfony/symfony-docs#7063

@dunglas
Copy link
Member

👍, can you also open a doc PR?

teohhanhui reacted with thumbs up emoji

@teohhanhui
Copy link
ContributorAuthor

I forgot to add test for invalid cases.

@teohhanhui
Copy link
ContributorAuthor

can you also open a doc PR?

Where should I add it? I see that theDateTimeNormalizer is mentioned in theNormalizers section.

/cc@weaverryan

@xabbuh
Copy link
Member

@teohhanhui I think your addition would fit there quite well (as long as there is no dedicated chapter about all the normalizers we have)

@teohhanhui
Copy link
ContributorAuthor

Documentation added.

@teohhanhuiteohhanhuiforce-pushed thedenormalize-datetime-format branch from54d7b75 toa72d997CompareOctober 17, 2016 08:04
@teohhanhui
Copy link
ContributorAuthor

Test case added for denormalize format mismatch.

@teohhanhuiteohhanhuiforce-pushed thedenormalize-datetime-format branch froma72d997 toff23924CompareOctober 17, 2016 08:06
@fabpot
Copy link
Member

Thank you@teohhanhui.

@fabpotfabpot merged commitff23924 intosymfony:masterOct 17, 2016
fabpot added a commit that referenced this pull requestOct 17, 2016
…malizer::denormalize (teohhanhui)This PR was merged into the 3.2-dev branch.Discussion----------[Serializer] Support specifying format for DateTimeNormalizer::denormalize| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | N/A| License       | MIT| Doc PR        |symfony/symfony-docs#7063Commits-------ff23924 [Serializer] Support specifying format for DateTimeNormalizer::denormalize
@teohhanhuiteohhanhui deleted the denormalize-datetime-format branchOctober 18, 2016 04:15
@fabpotfabpot mentioned this pull requestOct 27, 2016
wouterj added a commit to symfony/symfony-docs that referenced this pull requestNov 10, 2016
…alizer::denormalize (teohhanhui)This PR was merged into the master branch.Discussion----------[Serializer] Support specifying format for DateTimeNormalizer::denormalizeWaiting forsymfony/symfony#20217 to be merged.Commits-------57bf969 [Serializer] Support specifying format for DateTimeNormalizer::denormalize
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@teohhanhui@dunglas@xabbuh@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp