NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[WIP] added missing ClassExistenceResource checks#20189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

fabpot wants to merge1 commit intosymfony:masterfromfabpot:class-existence-resource-more

Closed

[WIP] added missing ClassExistenceResource checks#20189

fabpot wants to merge1 commit intosymfony:masterfromfabpot:class-existence-resource-more

Conversation

Copy link

Member

fabpot commentedOct 9, 2016

Q	A
Branch?	master
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	n/a
License	MIT
Doc PR	n/a

Continuation of#20121

added missing ClassExistenceResource checks

6263948

carsonbot added Status: Needs Review Bug labels

Oct 9, 2016

javiereguiluz added this to the3.2 milestone

Nov 7, 2016

fabpot removed this from the3.2 milestone

Nov 16, 2016

Copy link

MemberAuthor

fabpot commentedNov 26, 2016

We should also add a DirectoryExistenceResource for translations for instance. If we add translations in a bundle, we should regerenate the cache, which is not the case right now.

nicolas-grekas added this to the3.x milestone

Dec 6, 2016

chalasr mentioned this pull request

Jan 25, 2017

[DI] Add ContainerBuilder::fileExists() for checking/tracking resource existence#21408

Merged

Copy link

Member

chalasr commentedJan 29, 2017•
edited
Loading

Finished in#21408, fixing your last comment too.

fabpot closed this

Feb 1, 2017

nicolas-grekas added a commit that referenced this pull request

Feb 2, 2017

feature#21408[DI] Add ContainerBuilder::fileExists() for checking/t…

35a49fb

…racking resource existence (chalasr)This PR was merged into the 3.3-dev branch.Discussion----------[DI] Add ContainerBuilder::fileExists() for checking/tracking resource existence| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#20189,#20189 (comment)| License       | MIT| Doc PR        | n/a~~Finishes#20189 Adds a convenient `ContainerBuilder::fileExists()` method as suggested by Nicolas and use it to track resources in the FrameworkExtension, adding some missing ones.Commits-------6b556b8 [DI] Add ContainerBuilder::fileExists()

nicolas-grekas modified the milestones:3.x,3.3

Mar 24, 2017