Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

add toolbar & profiler SVG style classes#20161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
havvg wants to merge2 commits intosymfony:2.8fromhavvg:feature/profiler-svg-styles

Conversation

@havvg
Copy link
Contributor

QA
Bug fix?no
New feature?Technically, yes - but actually not
BC breaks?no
Deprecations?no
Tests pass?yes
LicenseMIT

This allows the usage of SVG not only containingpath elements. I opted for a generic solution using the two classes to apply to any SVG, one would like to use within the toolbar (sf-toolbar-path) and/or profiler (sf-profiler-path).

@stof
Copy link
Member

stof commentedOct 5, 2016

would be great to use the same class, to avoid having to add 2 classes in the SVG file (or to maintain 2 SVG files)

@havvg
Copy link
ContributorAuthor

Fine by me, what should I name the unified class?

@javiereguiluz
Copy link
Member

What about using.sf-svg-path as the single class name?

@havvg
Copy link
ContributorAuthor

havvg commentedNov 7, 2016•
edited
Loading

@javiereguiluz I renamed them.

@javiereguiluz
Copy link
Member

👍

@fabpot
Copy link
Member

Thank you@havvg.

@fabpotfabpot mentioned this pull requestMay 1, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@havvg@stof@javiereguiluz@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp