Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
added checks for public services on compiler passes that use service ids and not references#20112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fabpot commentedSep 30, 2016
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
| $loader =$container->getDefinition('twig.runtime_loader'); | ||
| $args =$loader->getArgument(1); | ||
| print_r($loader->getArguments()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This looks like a debug leftover
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
oops
| thrownewInvalidArgumentException(sprintf('The service "%s" must not be abstract as it can be lazy-loaded.',$id)); | ||
| } | ||
| $validators[$definition->getClass()] =$id; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
shouldn't this be done in older branches ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
see#20116
…id and not references
…se service ids and not references (fabpot)This PR was merged into the 3.2-dev branch.Discussion----------added checks for public services on compiler passes that use service ids and not references| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aCommits-------82fa942 added checks for public services on compiler passes that use service id and not references
| } | ||
| if ($def->isAbstract()) { | ||
| thrownewInvalidArgumentException(sprintf('The service "%s" must not be abstract as it can be lazy-loaded.',$id)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The message here is not very accurate. An abstract service is not "get() able". It's not about lazy-loading.