NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

fixed Twig support for 1.26 and 2.0#20079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:2.7fromfabpot:twig-upgrade

Sep 29, 2016

Merged

fixed Twig support for 1.26 and 2.0#20079

fabpot merged 1 commit intosymfony:2.7fromfabpot:twig-upgrade

Sep 29, 2016

Conversation

Copy link

Member

fabpot commentedSep 28, 2016

Q	A
Branch?	2.7
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	n/a
License	MIT
Doc PR	n/a

Removes the deprecation notices for Twig 1.26.

carsonbot added Status: Needs Review Bug labels

Sep 28, 2016

fabpot force-pushed thetwig-upgrade branch from09eebac to9db8fddCompare

September 28, 2016 23:07

fixed Twig support for 1.26 and 2.0

24e9cf2

fabpot force-pushed thetwig-upgrade branch from9db8fdd to24e9cf2Compare

September 29, 2016 01:04

fabpot merged commit24e9cf2 intosymfony:2.7

Sep 29, 2016

fabpot added a commit that referenced this pull request

Sep 29, 2016

bug#20079fixed Twig support for 1.26 and 2.0 (fabpot)

b4d5827

This PR was merged into the 2.7 branch.Discussion----------fixed Twig support for 1.26 and 2.0| Q             | A| ------------- | ---| Branch?       | 2.7| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | n/a| License       | MIT| Doc PR        | n/aRemoves the deprecation notices for Twig 1.26.Commits-------24e9cf2 fixed Twig support for 1.26 and 2.0

HeahDude mentioned this pull request

Sep 29, 2016

Fix #19943 Make sure to process each interface metadata only once#20078

Merged

1 task

fabpot deleted the twig-upgrade branch

October 1, 2016 05:07

Copy link

Contributor

ro0NL commentedOct 2, 2016•
edited
Loading

@fabpot this breaks deps.. there is no stable 1.26 release, only 1.26@dev.

Problem 1  - symfony/symfony 3.2.x-dev requires twig/twig ~1.26|~2.0 -> satisfiable by twig/twig[1.x-dev, 2.0.x-dev] but these conflict with your requirements or minimum-stability.

UndefinedMethodException in appDevDebugProjectContainer.php line 3154:Attempted to call an undefined method named "addRuntimeLoader" of class "Twig_Environment".

edit: i worked around it usingcomposer require twig/twig:@dev