Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] removed the Asset component dependency on FrameworkBundle#20067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
4a6cd91 toc2ddb68Comparexabbuh commentedSep 28, 2016
👍 By the way, I do not think that this change will not be breaking some applications. In my experience there are way to many packages out there that require the FrameworkBundle instead of explicitly listing their dependencies. Probably, not many of them will break because of the missing Asset component, but we will probably have to expect some (a lot of) reports when doing similar changes with other component. Though maybe this helps to educate people to be more explicit with what their packages actually really need without pulling the whole universe. |
| * {@inheritdoc} | ||
| */ | ||
| publicfunctionisEnabled() | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't think this command uses anything from the asset component and so could stay enabled if the component isn't installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oops, you're right, reverted
c2ddb68 to1dd4e21Compare…cy on FrameworkBundle (fabpot)This PR was merged into the 3.2-dev branch.Discussion----------[FrameworkBundle] removed the Asset component dependency on FrameworkBundle| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no (except for people using FrameworkBundle without requiring symfony/symfony which should be pretty rare; and fixing this is easy by adding symfony/asset explicitly)| Deprecations? | no| Tests pass? | yes| Fixed tickets |#15748 partially| License | MIT| Doc PR | n/aTrying to reduce the number of required dependencies on FrameworkBundle. This PR removes the Asset component from the list.Commits-------1dd4e21 [FrameworkBundle] removed the Asset component dependency on FrameworkBundle
Uh oh!
There was an error while loading.Please reload this page.
Trying to reduce the number of required dependencies on FrameworkBundle. This PR removes the Asset component from the list.