Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Console] Different approach on merging application definition#20054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromro0NL:console/command-arguments
Aug 13, 2020
Merged

[Console] Different approach on merging application definition#20054

fabpot merged 1 commit intosymfony:masterfromro0NL:console/command-arguments
Aug 13, 2020

Conversation

@ro0NL
Copy link
Contributor

@ro0NLro0NL commentedSep 25, 2016
edited
Loading

QA
Branch?"master"
Bug fix?yes
New feature?not really (refactoring)
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#19181,#17804,#19909, partially#20030
LicenseMIT
Doc PRreference to the documentation PR, if any

Before/After:

$ bin/console list -hUsage:  list [options] [--] [<namespace>]Arguments:  namespace            The namespace nameOptions:      --raw            To output raw command list      --format=FORMAT  The output format (txt, xml, json, or md) [default: "txt"]+  -h, --help            Display this help message+  -q, --quiet           Do not output any message+  -V, --version         Display this application version+      --ansi            Force ANSI output+      --no-ansi         Disable ANSI output+  -n, --no-interaction  Do not ask any interactive question+  -e, --env=ENV         The environment name [default: "dev"]+      --no-debug        Switches off debug mode+  -v|vv|vvv, --verbose  Increase the verbosity of messages: 1 for normal output, 2 for more verbose output and 3 for debugHelp:  The list command lists all commands:    php bin/console list  You can also display the commands for a specific namespace:    php bin/console list test  You can also output the information in other formats by using the --format option:    php bin/console list --format=xml  It's also possible to get raw list of commands (useful for embedding command runner):    php bin/console list --raw

This could deprecategetNativeDefinition or make it a feature as right now it's internal and unused.

edit: resolved the BC break.

edit2: question is.. should this target 2.7?

@ro0NL
Copy link
ContributorAuthor

ro0NL commentedSep 28, 2016
edited
Loading

So.. any thoughts on this? I think this is way more obvious than the current approach.

The list command not giving the application-wide options is a bug.. right? However they were more or less explicitly left out... any opinion on this?

edit: yeah.. after#20090 and rebase 2.7 imo.

@ro0NL
Copy link
ContributorAuthor

ro0NL commentedDec 29, 2016
edited
Loading

Not sure about intentions here. It's done rather explicitly. The global options do work though withlist.

@ro0NLro0NL closed thisDec 29, 2016
@ro0NLro0NL deleted the console/command-arguments branchDecember 29, 2016 09:50
@nicolas-grekasnicolas-grekas modified the milestones:3.x,3.3Mar 24, 2017
@l-vo
Copy link
Contributor

Tested the changes on 3.4 and this approach seems to be working properly.

@ro0NLro0NL restored the console/command-arguments branchNovember 30, 2018 07:36
@ro0NLro0NL reopened thisNov 30, 2018
@ro0NL
Copy link
ContributorAuthor

status: needs work

@fabpot
Copy link
Member

@ro0NL I'm digging the old PRs right now and stumbled on this one. I see that you marked it as "Needs work", is it still relevant?

@ro0NL
Copy link
ContributorAuthor

@fabpot i'd say yes. It boils down to

bin/console list -h# does NOT show global optionsbin/console about -h# does show global optionsbin/console help -h# does show global options# includes an arbitrary "command" argument, e.g.;##   Arguments:#     command               The command to execute#     command_name          The command name [default: "help"]

Not sure why i marked it "needs work" 😅 i figure to come to some sort of conslusion here.

@fabpot
Copy link
Member

Ok, can you rebase on current master? I will test it on a real application to see how it behaves.

@ro0NL
Copy link
ContributorAuthor

ro0NL commentedAug 11, 2020
edited
Loading

@fabpot should be good.Only need to update fixture files still (please do 😂)

@ro0NL
Copy link
ContributorAuthor

@fabpot console component passes tests 👍

Copy link
Member

@fabpotfabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great job!

@fabpot
Copy link
Member

Thank you@ro0NL.

@fabpotfabpot merged commita45428c intosymfony:masterAug 13, 2020
@ro0NLro0NL deleted the console/command-arguments branchSeptember 8, 2020 16:51
@nicolas-grekasnicolas-grekas modified the milestones:next,5.2Oct 5, 2020
@fabpotfabpot mentioned this pull requestOct 5, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

+1 more reviewer

@l-vol-vol-vo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

6 participants

@ro0NL@l-vo@fabpot@nicolas-grekas@chalasr@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp