Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] Change FormTypeGuesserChain to accept Traversable#20047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| foreach ($guessersas$guesser) { | ||
| if (!$guesserinstanceof FormTypeGuesserInterface) { | ||
| thrownewUnexpectedTypeException($guesser,'Symfony\Component\Form\FormTypeGuesserInterface'); | ||
| thrownewUnexpectedTypeException($guesser, FormTypeGuesserInterface::class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should be reverted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It seemed logical to make this change but if you say so... reverted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Problem is that's causing merge conflicts when merging older branches in the newer onces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oh. That explains why Symfony still uses the old array syntax too. Thank you!
enumag commentedOct 19, 2016
@fabpot Anything else to do here? |
fabpot commentedOct 19, 2016
Thank you@enumag. |
…le (enumag)This PR was merged into the 3.2-dev branch.Discussion----------[Form] Change FormTypeGuesserChain to accept Traversable| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |I'm using symfony/form without the rest of the framework and this will make things a bit easier for me.Commits-------5e4f4d4 [Form] Change FormTypeGuesserChain to accept Traversable
I'm using symfony/form without the rest of the framework and this will make things a bit easier for me.