Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[ExpressionLanguage] fixed a BC break#20015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromfabpot:fix-bc-break
Sep 21, 2016

Conversation

@fabpot
Copy link
Member

QA
Branch?master
Bug fix?yes
New feature?no
BC breaks?fixes a BC break :)
Deprecations?no
Tests pass?yes
Fixed ticketssee#19060 (comment)
LicenseMIT
Doc PRn/a

@fabpot
Copy link
MemberAuthor

ping@nicolas-grekas@lyrixx

@nicolas-grekas
Copy link
Member

For reference, this was done to ease with dumping AST. With NameNode,$foo->foo() is dumped as is.
With this change, it will be dumped as$foo->"foo"().
But BC is of paramount importance, so 👍
Maybe adjustNode::dump() to deal with this case thought?

@fabpot
Copy link
MemberAuthor

@nicolas-grekas Indeed, tweakingdump() to take care of that would be ideal. Can you prepare a patch?

@nicolas-grekas
Copy link
Member

Would it be OK to add a new node type that extendsConstantNode, to be used in this case? Because unescaping strings while dumping has some code smell to me.

@fabpot
Copy link
MemberAuthor

Not sure :)

@fabpotfabpot merged commitb00930f intosymfony:masterSep 21, 2016
fabpot added a commit that referenced this pull requestSep 21, 2016
This PR was merged into the 3.2-dev branch.Discussion----------[ExpressionLanguage] fixed a BC break| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| BC breaks?    | fixes a BC break :)| Deprecations? | no| Tests pass?   | yes| Fixed tickets | see#19060 (comment)| License       | MIT| Doc PR        | n/aCommits-------b00930f [ExpressionLanguage] fixed a BC break
@fabpotfabpot deleted the fix-bc-break branchSeptember 28, 2016 14:38
@fabpotfabpot mentioned this pull requestOct 27, 2016
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fabpot@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp