Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Translation] added Base Exception for the component.#20012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
aitboudad commentedSep 21, 2016
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | ~ |
| License | MIT |
| Doc PR | ~ |
xabbuh left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 (apart from the minor comment)
| $xmlUri ='informativeCopiesOf3rdPartySchemas/w3c/xml.xsd'; | ||
| }else { | ||
| thrownew\InvalidArgumentException(sprintf('No support implemented for loading XLIFF version "%s".',$xliffVersion)); | ||
| thrownewInvalidArgumentException(sprintf('No support implemented for loading XLIFF version "%s".',$xliffVersion)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
use statement is missing, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fixed thanks, FYI I updated the docblock too@throws InvalidArgumentException
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Are there other@throws annotation that need to be updated accordingly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
yes updated all needed ones
0fa2bce to0fa4397Comparexabbuh commentedSep 21, 2016
👍 Status: Reviewed |
fabpot commentedSep 21, 2016
Thank you@aitboudad. |
…(aitboudad)This PR was merged into the 3.2-dev branch.Discussion----------[Translation] added Base Exception for the component.| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | ~| License | MIT| Doc PR | ~Commits-------0fa4397 [Translation] added Base Exception for the component.
This PR was merged into the 3.2 branch.Discussion----------[FrameworkBundle] Fix translation dep constraint| Q | A| ------------- | ---| Branch? | 3.2| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | n/aThe framework Translator makes use of the Translator component domain exceptions which exist since 3.2 only, leading to a fatal error when one of these exceptions is thrown in the framework using `symfony/translations:<3.2`. Bug introduced in#20012Commits-------e1caf7d [FrameworkBundle] Fix translation dep constraint