Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Use UUID for error codes for Form validator.#20011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
Koc wants to merge1 commit intosymfony:2.8fromKoc:form-validator-uuid

Conversation

@Koc
Copy link
Contributor

@KocKoc commentedSep 21, 2016•
edited
Loading

QA
Branch?2.8
Bug fix?no
New feature?no
BC breaks?tiny, but it allowedhttp://symfony.com/doc/current/contributing/code/bc.html#changing-classes
Deprecations?no
Tests pass?I hope so :)
Fixed tickets-
LicenseMIT
Doc PR-

linaori reacted with thumbs up emoji
2.8.12
-----

*[BC BREAK] Changed values of the Symfony\Component\Form\Extension\Validator\Constraints\Form constants.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We cannot have a BC break in a patch release. Is it really a BC break? People MUST use the constant anyway, not the value.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ok, so can I just remove[BC BREAK] from the changelog?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You should remove everything here :) Changelogs for patch versions are generated automatically.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@fabpot done!

@fabpot
Copy link
Member

👍

@fabpot
Copy link
Member

Thank you@Koc.

fabpot added a commit that referenced this pull requestSep 21, 2016
This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes#20011).Discussion----------Use UUID for error codes for Form validator.| Q             | A| ------------- | ---| Branch?       | 2.8| Bug fix?      | no| New feature?  | no| BC breaks?    | tiny, but it allowedhttp://symfony.com/doc/current/contributing/code/bc.html#changing-classes| Deprecations? | no| Tests pass?   | I hope so :)| Fixed tickets | -| License       | MIT| Doc PR        | -Commits-------6dbb186 Use UUID for error codes for Form validator.
@fabpotfabpot closed thisSep 21, 2016
@Koc
Copy link
ContributorAuthor

Koc commentedSep 21, 2016

@fabpot I've choosen 2.8 branch because uuid codes was added in 2.8, not in 2.7

@Koc
Copy link
ContributorAuthor

Koc commentedSep 21, 2016

See#15154 for details

@xabbuh
Copy link
Member

I agree with@Koc. We should revert the merge on the2.7 branch and merge it into2.8 afterwards.

@fabpot
Copy link
Member

Oops, sorry about that. Going to fix that now.

fabpot added a commit that referenced this pull requestSep 21, 2016
@fabpot
Copy link
Member

fabpot commentedSep 21, 2016•
edited
Loading

Done

xabbuh reacted with thumbs up emoji

fabpot added a commit that referenced this pull requestSep 21, 2016
* 2.7:  Revert "minor#20011 Use UUID for error codes for Form validator. (Koc)"  Use UUID for error codes for Form validator.  Fixed regression when exception message swallowed when logging it.  [HttpFoundation] Enable memcached tests with the latest memcached extension
fabpot added a commit that referenced this pull requestSep 21, 2016
This PR was merged into the 2.8 branch.Discussion----------Use UUID for error codes for Form validator.| Q             | A| ------------- | ---| Branch?       | 2.8| Bug fix?      | no| New feature?  | no| BC breaks?    | tiny, but it allowedhttp://symfony.com/doc/current/contributing/code/bc.html#changing-classes| Deprecations? | no| Tests pass?   | I hope so :)| Fixed tickets | -| License       | MIT| Doc PR        | -Commits-------3693e83 Use UUID for error codes for Form validator.
fabpot added a commit that referenced this pull requestSep 21, 2016
* 2.8:  [VarDumper] Fix test  Revert "minor#20011 Use UUID for error codes for Form validator. (Koc)"  Use UUID for error codes for Form validator.  Use UUID for error codes for Form validator.  Fixed regression when exception message swallowed when logging it.  [HttpFoundation] Enable memcached tests with the latest memcached extension
fabpot added a commit that referenced this pull requestSep 21, 2016
* 3.1:  [VarDumper] Fix test  Revert "minor#20011 Use UUID for error codes for Form validator. (Koc)"  Use UUID for error codes for Form validator.  Use UUID for error codes for Form validator.  Fixed regression when exception message swallowed when logging it.  [HttpFoundation] Enable memcached tests with the latest memcached extension
@KocKoc deleted the form-validator-uuid branchSeptember 23, 2016 19:56
@KocKoc restored the form-validator-uuid branchSeptember 23, 2016 21:43
This was referencedOct 3, 2016
@KocKoc deleted the form-validator-uuid branchJuly 23, 2017 10:11
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot left review comments

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Koc@fabpot@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp