Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
Renaming "Entities" to "Entity"#2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
maoueh pushed a commit to maoueh/symfony that referenced this pull requestMay 21, 2011
fabpot added a commit that referenced this pull requestJul 27, 2011
Commits-------07298ac Detect EOF when reading input streamDiscussion----------[Console] Detect EOF when reading input streamThis is related to commits511a9a1 and3a5d508.First of them introduced abort-on-EOF and the second regressed the functionality.Problem is stream_get_line() doesn't return false on EOF. So it needs call to feof() todetect the situation.Still, it's not ideal. With fgets() it worked fine, but with stream_get_line() one has to pressCTRL+D twice to get out. I presume this could be bug in PHP itself.But better than nothing. Please consider.---------------------------------------------------------------------------by fabpot at 2011/07/19 22:47:53 -0700I have used `stream_get_line` especially because it does not return `false` on eof. This is needed when you pass your own stream for unit tests.---------------------------------------------------------------------------by lenar at 2011/07/25 06:05:59 -0700This is not the best solution I think. Tests should mimic and cope with real life not the other way around.Better solution would be to fix testcase. Like this:lenar/SensioGeneratorBundle@6ff3f26. Or maybe create a special "testing" stream wrapper that wraps php://memory and gives out just linefeeds after real data ends.And then change stream_get_line() back to fgets() if there is no other reason for this change.---------------------------------------------------------------------------by fabpot at 2011/07/25 06:24:20 -0700When applying your patch to the generator bundle (and revert to use `fgets`), I get "RuntimeException: Aborted" exceptions.---------------------------------------------------------------------------by lenar at 2011/07/25 06:35:08 -0700With d326f89 added +lenar/SensioGeneratorBundle@6ff3f26 I can successfully run every test in that file.---------------------------------------------------------------------------by fabpot at 2011/07/26 23:31:36 -0700@lenar: not for me. I have many 'Aborted' exception on my Mac.---------------------------------------------------------------------------by fabpot at 2011/07/26 23:41:18 -0700And I have the exact same errors on Linux: There were 7 errors: 1) Sensio\Bundle\GeneratorBundle\Tests\Command\GenerateBundleCommandTest::testInteractiveCommand with data set #0 (array('/tmp'), 'Foo/BarBundle ', array('Foo\\BarBundle', 'FooBarBundle', '/tmp/', 'annotation', false)) RuntimeException: Aborted .../Symfony/Component/Console/Helper/DialogHelper.php:40 .../Symfony/Component/Console/Helper/DialogHelper.php:97 .../symfony-standard/vendor/bundles/Sensio/Bundle/GeneratorBundle/Command/GenerateBundleCommand.php:165 .../Symfony/Component/Console/Command/Command.php:205 .../Symfony/Component/Console/Tester/CommandTester.php:66 .../symfony-standard/vendor/bundles/Sensio/Bundle/GeneratorBundle/Tests/Command/GenerateBundleCommandTest.php:39 2) Sensio\Bundle\GeneratorBundle\Tests\Command\GenerateBundleCommandTest::testInteractiveCommand with data set#1 (array('/tmp'), 'Foo/BarBundle BarBundle foo yml n', array('Foo\\BarBundle', 'BarBundle', 'foo/', 'yml', false)) RuntimeException: Aborted .../Symfony/Component/Console/Helper/DialogHelper.php:40 .../Symfony/Component/Console/Helper/DialogHelper.php:62 .../symfony-standard/vendor/bundles/Sensio/Bundle/GeneratorBundle/Command/GenerateBundleCommand.php:83 .../Symfony/Component/Console/Command/Command.php:214 .../Symfony/Component/Console/Tester/CommandTester.php:66 .../symfony-standard/vendor/bundles/Sensio/Bundle/GeneratorBundle/Tests/Command/GenerateBundleCommandTest.php:39 3) Sensio\Bundle\GeneratorBundle\Tests\Command\GenerateBundleCommandTest::testInteractiveCommand with data set#2 (array('/tmp', 'yml', 'BarBundle', true), 'Foo/BarBundle ', array('Foo\\BarBundle', 'BarBundle', '/tmp/', 'yml', true)) RuntimeException: Aborted .../Symfony/Component/Console/Helper/DialogHelper.php:40 .../Symfony/Component/Console/Helper/DialogHelper.php:97 .../symfony-standard/vendor/bundles/Sensio/Bundle/GeneratorBundle/Command/GenerateBundleCommand.php:165 .../Symfony/Component/Console/Command/Command.php:205 .../Symfony/Component/Console/Tester/CommandTester.php:66 .../symfony-standard/vendor/bundles/Sensio/Bundle/GeneratorBundle/Tests/Command/GenerateBundleCommandTest.php:39 4) Sensio\Bundle\GeneratorBundle\Tests\Command\GenerateDoctrineEntityCommandTest::testInteractiveCommand with data set #0 (array(), 'AcmeBlogBundle:Blog/Post ', array('Blog\\Post', 'annotation', array())) RuntimeException: Aborted .../Symfony/Component/Console/Helper/DialogHelper.php:40 .../Symfony/Component/Console/Helper/DialogHelper.php:97 .../symfony-standard/vendor/bundles/Sensio/Bundle/GeneratorBundle/Command/GenerateDoctrineEntityCommand.php:145 .../Symfony/Component/Console/Command/Command.php:205 .../Symfony/Component/Console/Tester/CommandTester.php:66 .../symfony-standard/vendor/bundles/Sensio/Bundle/GeneratorBundle/Tests/Command/GenerateDoctrineEntityCommandTest.php:39 5) Sensio\Bundle\GeneratorBundle\Tests\Command\GenerateDoctrineEntityCommandTest::testInteractiveCommand with data set#1 (array('AcmeBlogBundle:Blog/Post'), '', array('Blog\\Post', 'annotation', array())) RuntimeException: Aborted .../Symfony/Component/Console/Helper/DialogHelper.php:40 .../Symfony/Component/Console/Helper/DialogHelper.php:97 .../symfony-standard/vendor/bundles/Sensio/Bundle/GeneratorBundle/Command/GenerateDoctrineEntityCommand.php:121 .../Symfony/Component/Console/Command/Command.php:205 .../Symfony/Component/Console/Tester/CommandTester.php:66 .../symfony-standard/vendor/bundles/Sensio/Bundle/GeneratorBundle/Tests/Command/GenerateDoctrineEntityCommandTest.php:39 6) Sensio\Bundle\GeneratorBundle\Tests\Command\GenerateDoctrineEntityCommandTest::testInteractiveCommand with data set#2 (array(), 'AcmeBlogBundle:Blog/Post yml ', array('Blog\\Post', 'yml', array())) RuntimeException: Aborted .../Symfony/Component/Console/Helper/DialogHelper.php:40 .../Symfony/Component/Console/Helper/DialogHelper.php:62 .../symfony-standard/vendor/bundles/Sensio/Bundle/GeneratorBundle/Command/GenerateDoctrineEntityCommand.php:153 .../Symfony/Component/Console/Command/Command.php:205 .../Symfony/Component/Console/Tester/CommandTester.php:66 .../symfony-standard/vendor/bundles/Sensio/Bundle/GeneratorBundle/Tests/Command/GenerateDoctrineEntityCommandTest.php:39 7) Sensio\Bundle\GeneratorBundle\Tests\Command\GenerateDoctrineEntityCommandTest::testInteractiveCommand with data set#3 (array(), 'AcmeBlogBundle:Blog/Post yml title 255 description text ', array('Blog\\Post', 'yml', array(array('title', 'string', 255), array('description', 'text')))) RuntimeException: Aborted .../Symfony/Component/Console/Helper/DialogHelper.php:40 .../Symfony/Component/Console/Helper/DialogHelper.php:62 .../symfony-standard/vendor/bundles/Sensio/Bundle/GeneratorBundle/Command/GenerateDoctrineEntityCommand.php:153 .../Symfony/Component/Console/Command/Command.php:205 .../Symfony/Component/Console/Tester/CommandTester.php:66 .../symfony-standard/vendor/bundles/Sensio/Bundle/GeneratorBundle/Tests/Command/GenerateDoctrineEntityCommandTest.php:39---------------------------------------------------------------------------by lenar at 2011/07/26 23:56:46 -0700@fabpot: and you modified all those tests? I only modified ```Tests/Command/GenerateDoctrineCrudCommandTest.php```and that doesn't fail as I see from your log. I just provided example, though I could add necessary changes for other tests too.---------------------------------------------------------------------------by fabpot at 2011/07/27 00:09:32 -0700@lenar: ah, sorry about that. Then, can you provide a fix for all the other tests too? Thanks a lot.---------------------------------------------------------------------------by lenar at 2011/07/27 00:22:54 -0700@fabpot: actually what do you think about this kind of fix instead for tests:lenar/SensioGeneratorBundle@517f263cb01ea2ea1ef2 instead my previous proposal (lenar/SensioGeneratorBundle@6ff3f26). Really simple, short and effective.---------------------------------------------------------------------------by fabpot at 2011/07/27 00:37:51 -0700@lenar: looks good to me. Can you create a PR?---------------------------------------------------------------------------by lenar at 2011/07/27 00:45:36 -0700@fabpot:sensiolabs/SensioGeneratorBundle#60
Merged
fabpot pushed a commit that referenced this pull requestNov 17, 2012
remove logic that could not be triggered anyway
fabpot added a commit that referenced this pull requestNov 17, 2012
This PR was merged into the master branch.Commits-------a146156 Merge pull request#2 from Tobion/patch-238802ea remove logic that could not be triggered anywayf7ea68f [Routing] Fixed undefined variable + typoDiscussion----------[Routing] Fixed typo + removed dead code---------------------------------------------------------------------------by Tobion at 2012-11-17T16:00:04Z@pborreli: pborreli/symfony#2---------------------------------------------------------------------------by pborreli at 2012-11-17T16:02:08Z@Tobion totally agree, tried to setup a phpunit test which could trigger this exception but couldn't ..
dawehner pushed a commit to dawehner/symfony that referenced this pull requestJul 1, 2013
[WIP] some refactoring to make the ContentRouter more flexible
dawehner pushed a commit to dawehner/symfony that referenced this pull requestJul 1, 2013
template must be _template
fabpot added a commit that referenced this pull requestApr 30, 2014
This PR was merged into the 2.3 branch.Discussion----------[2.3] Fix phpunit test suite on travis#2| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#10821| License | MITThis is a second approach to solve#10821.Something is weird: `Symfony\Component\Form\Tests\Extension\Core\EventListener\TrimListenerTest` passes when using PHPUnit as phar and fails when using a composer global installCommits-------32e5f67 [DependencyInjection] Fix travis unit testsc7befd5 Update PHPUnit before run
Closed
webmozart added a commit that referenced this pull requestSep 30, 2014
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#11998).Discussion----------[Intl] Integrated ICU data into Intl component#2| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Follow-up PR to#11920. This PR contains generated data files only.Commits-------65a8b9f [Intl] Generated the data for ICU version 54-rc
fabpot added a commit that referenced this pull requestOct 5, 2014
This PR was merged into the 2.6-dev branch.Discussion----------[VarDumper] Dynamic HTML dumper| Q | A| ------------- | ---| Bug fix? | yes| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#12109| License | MIT| Doc PR | -This PR partially reverts#12109 because it didn't take into account that many dumps can share a single style tag.More importantly, this PR enhance dump rendering with some cute JS navigation effects:- references highlighting on hovering- moving references togglingHere is a screenshot (note the yellow background and the fact that `#2` appears after the first `@2`):Commits-------b799844 [VarDumper] Dynamic HTML dumper
fabpot added a commit that referenced this pull requestDec 12, 2014
This PR was submitted for the master branch but it was merged into the 2.5 branch instead (closes#12453).Discussion----------[Debug] Show only unique class candidates| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -```PHPUnit 4.3.5 by Sebastian Bergmann.Configuration read from .../symfony/phpunit.xml.distS....S.............................FFFS.......Time: 2.29 seconds, Memory: 8.50MbThere were 3 failures:1) Symfony\Component\Debug\Tests\FatalErrorHandler\ClassNotFoundFatalErrorHandlerTest::testClassNotFound with data set#2 (array(1, 12, 'foo.php', 'Class \'UndefinedFunctionException\' not found'), 'Attempted to load class "UndefinedFunctionException" from the global namespace.Did you forget a "use" statement for "Symfony\\Component\\Debug\\Exception\\UndefinedFunctionException"?')Failed asserting that two strings are identical.--- Expected+++ Actual@@ @@ Attempted to load class "UndefinedFunctionException" from the global namespace.-Did you forget a "use" statement for "Symfony\Component\Debug\Exception\UndefinedFunctionException"?+Did you forget a "use" statement for e.g. "Symfony\Component\Debug\Exception\UndefinedFunctionException" or "Symfony\Component\Debug\Exception\UndefinedFunctionException"?.../symfony/src/Symfony/Component/Debug/Tests/FatalErrorHandler/ClassNotFoundFatalErrorHandlerTest.php:282) Symfony\Component\Debug\Tests\FatalErrorHandler\ClassNotFoundFatalErrorHandlerTest::testClassNotFound with data set#3 (array(1, 12, 'foo.php', 'Class \'PEARClass\' not found'), 'Attempted to load class "PEARClass" from the global namespace.Did you forget a "use" statement for "Symfony_Component_Debug_Tests_Fixtures_PEARClass"?')Failed asserting that two strings are identical.--- Expected+++ Actual@@ @@ Attempted to load class "PEARClass" from the global namespace.-Did you forget a "use" statement for "Symfony_Component_Debug_Tests_Fixtures_PEARClass"?+Did you forget a "use" statement for e.g. "Symfony_Component_Debug_Tests_Fixtures_PEARClass" or "Symfony_Component_Debug_Tests_Fixtures_PEARClass"?.../symfony/src/Symfony/Component/Debug/Tests/FatalErrorHandler/ClassNotFoundFatalErrorHandlerTest.php:283) Symfony\Component\Debug\Tests\FatalErrorHandler\ClassNotFoundFatalErrorHandlerTest::testClassNotFound with data set#4 (array(1, 12, 'foo.php', 'Class \'Foo\\Bar\\UndefinedFunctionException\' not found'), 'Attempted to load class "UndefinedFunctionException" from namespace "Foo\\Bar".Did you forget a "use" statement for "Symfony\\Component\\Debug\\Exception\\UndefinedFunctionException"?')Failed asserting that two strings are identical.--- Expected+++ Actual@@ @@ Attempted to load class "UndefinedFunctionException" from namespace "Foo\Bar".-Did you forget a "use" statement for "Symfony\Component\Debug\Exception\UndefinedFunctionException"?+Did you forget a "use" statement for e.g. "Symfony\Component\Debug\Exception\UndefinedFunctionException" or "Symfony\Component\Debug\Exception\UndefinedFunctionException"?.../symfony/src/Symfony/Component/Debug/Tests/FatalErrorHandler/ClassNotFoundFatalErrorHandlerTest.php:28```Commits-------db8a3ae [Debug] Show only unique class candidates
fabpot pushed a commit that referenced this pull requestJan 16, 2015
Add comment as requested - see comment for stof
nicolas-grekas added a commit that referenced this pull requestOct 17, 2023
…eld type inside array (l-naumann)This PR was squashed before being merged into the 6.4 branch.Discussion----------[Mime] Throw InvalidArgumentException on invalid form field type inside array| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | n/a| License | MITExample code:```php$f = new FormDataPart([ 'foo' => [ 'bar' => 'baz', 'qux' => [ 'quux' => 1, ], ], ]);$f->getParts();```Currently, when you use a disallowed type inside an array, a TypeError is thrown:` Symfony\Component\Mime\Part\Multipart\FormDataPart::configurePart(): Argument#2 ($part) must be of type Symfony\Component\Mime\Part\TextPart, int given`This change adds a clearly understandable error message:`The value of the form field "foo[qux][quux]" can only be a string, an array, or an instance of TextPart ("int" given).`Commits-------08f5d7c [Mime] Throw InvalidArgumentException on invalid form field type inside array
fabpot added a commit that referenced this pull requestJan 19, 2024
This PR was merged into the 5.4 branch.Discussion----------[Process] Fixed inconsistent test| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues | N/A| License | MITSometimes the process no longer appears to be running when the signal is sent which causes a LogicException to be thrown. This doesn't appear to be consistent and I can reproduce it randomly on my local machine. To avoid having tests fail at random I decided that it's better to send the signal only if the process is still marked as running.```bashamne@wnbpowerbox:~/work/projects/symfony$ php7.4 src/Symfony/Component/Process/Tests/ErrorProcessInitiator.phpThe process "'php' '-r' 'echo '\''ready'\''; trigger_error('\''error'\'', E_USER_ERROR);'" exceeded the timeout of 0.5 seconds.amne@wnbpowerbox:~/work/projects/symfony$ php7.4 src/Symfony/Component/Process/Tests/ErrorProcessInitiator.phpThe process "'php' '-r' 'echo '\''ready'\''; trigger_error('\''error'\'', E_USER_ERROR);'" exceeded the timeout of 0.5 seconds.amne@wnbpowerbox:~/work/projects/symfony$ php7.4 src/Symfony/Component/Process/Tests/ErrorProcessInitiator.phpThe process "'php' '-r' 'echo '\''ready'\''; trigger_error('\''error'\'', E_USER_ERROR);'" exceeded the timeout of 0.5 seconds.amne@wnbpowerbox:~/work/projects/symfony$ php7.4 src/Symfony/Component/Process/Tests/ErrorProcessInitiator.phpThe process "'php' '-r' 'echo '\''ready'\''; trigger_error('\''error'\'', E_USER_ERROR);'" exceeded the timeout of 0.5 seconds.amne@wnbpowerbox:~/work/projects/symfony$ php7.4 src/Symfony/Component/Process/Tests/ErrorProcessInitiator.phpPHP Fatal error: Uncaught Symfony\Component\Process\Exception\LogicException: Cannot send signal on a non running process. in /home/amne/work/projects/symfony/src/Symfony/Component/Process/Process.php:1502Stack trace:#0 /home/amne/work/projects/symfony/src/Symfony/Component/Process/Process.php(516): Symfony\Component\Process\Process->doSignal()#1 /home/amne/work/projects/symfony/src/Symfony/Component/Process/Tests/ErrorProcessInitiator.php(28): Symfony\Component\Process\Process->signal()#2 {main} thrown in /home/amne/work/projects/symfony/src/Symfony/Component/Process/Process.php on line 1502```Commits-------00ee4ca [Process] Fixed inconsistent test
nicolas-grekas added a commit that referenced this pull requestJan 29, 2024
…om socket (xdanik)This PR was merged into the 5.4 branch.Discussion----------[Mailer] Throw `TransportException` when unable to read from socket| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? |no| Issues | None| License | MITWe are seeing error `fgets(): SSL: Connection reset by peer` multiple times a day from connection to Office 365 SMTP server (smtp.office365.com:587).It's certainly related to some kind of timeout as we are sending emails from long running queue dispatcher and error shows up only occasionally and never with the first message. We are not seeing this issue with any other SMTP server, but we have not tested much past smtp.mandrillapp.com and local MailHog.We have tried adjusting the `$pingThreshold` and `$restartThreshold` options, but without much success (well `$restartThreshold = 1` resolves the issue, but it also forces the transport to close connection after each message).Stack trace:```#0 /var/www/vendor/symfony/mailer/Transport/Smtp/Stream/AbstractStream.php(77): fgets(Resource(stream))#1 /var/www/vendor/symfony/mailer/Transport/Smtp/SmtpTransport.php(315): Symfony\Component\Mailer\Transport\Smtp\Stream\AbstractStream->readLine()#2 /var/www/vendor/symfony/mailer/Transport/Smtp/SmtpTransport.php(181): Symfony\Component\Mailer\Transport\Smtp\SmtpTransport->getFullResponse()#3 /var/www/vendor/symfony/mailer/Transport/Smtp/SmtpTransport.php(140): Symfony\Component\Mailer\Transport\Smtp\SmtpTransport->executeCommand("RSET", Array(1))#4 /var/www/vendor/symfony/mailer/Mailer.php(45): Symfony\Component\Mailer\Transport\Smtp\SmtpTransport->send(Object(Symfony\Component\Mime\Email), Null)#5 (our queue dispatcher): Symfony\Component\Mailer\Mailer->send(Object(Symfony\Component\Mime\Email))```App is running on PHP 8.0.28 on Debian Linux x64, Mailer v5.4.22.I would gladly written some tests for this, but I don't know how to simulate calls to low-level stream functions like fgets.Commits-------44d5b57 [Mailer] Throw TransportException when unable to read from socket
chalasr added a commit that referenced this pull requestMar 5, 2024
…lishing a message. (jwage)This PR was squashed before being merged into the 6.4 branch.Discussion----------[Messenger] [Amqp] Handle AMQPConnectionException when publishing a message.| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues |Fix#36538Fix#48241| License | MITIf you have a message handler that dispatches messages to another queue, you can encounter `AMQPConnectionException` with the message "Library error: a SSL error occurred" or "a socket error occurred" depending on if you are using tls or not or if you are running behind a load balancer or not.You can manually reproduce this issue by dispatching a message where the handler then dispatches another message to a different queue, then go to rabbitmq admin and close the connection manually, then dispatch another message and when the message handler goes to dispatch the other message, you will get this exception:```a socket error occurred#0 /vagrant/vendor/symfony/amqp-messenger/Transport/AmqpTransport.php(60): Symfony\Component\Messenger\Bridge\Amqp\Transport\AmqpSender->send()#1 /vagrant/vendor/symfony/messenger/Middleware/SendMessageMiddleware.php(62): Symfony\Component\Messenger\Bridge\Amqp\Transport\AmqpTransport->send()#2 /vagrant/vendor/symfony/messenger/Middleware/FailedMessageProcessingMiddleware.php(34): Symfony\Component\Messenger\Middleware\SendMessageMiddleware->handle()#3 /vagrant/vendor/symfony/messenger/Middleware/DispatchAfterCurrentBusMiddleware.php(61): Symfony\Component\Messenger\Middleware\FailedMessageProcessingMiddleware->handle()#4 /vagrant/vendor/symfony/messenger/Middleware/RejectRedeliveredMessageMiddleware.php(41): Symfony\Component\Messenger\Middleware\DispatchAfterCurrentBusMiddleware->handle()#5 /vagrant/vendor/symfony/messenger/Middleware/AddBusNameStampMiddleware.php(37): Symfony\Component\Messenger\Middleware\RejectRedeliveredMessageMiddleware->handle()#6 /vagrant/vendor/symfony/messenger/Middleware/TraceableMiddleware.php(40): Symfony\Component\Messenger\Middleware\AddBusNameStampMiddleware->handle()#7 /vagrant/vendor/symfony/messenger/MessageBus.php(70): Symfony\Component\Messenger\Middleware\TraceableMiddleware->handle()#8 /vagrant/vendor/symfony/messenger/TraceableMessageBus.php(38): Symfony\Component\Messenger\MessageBus->dispatch()#9 /vagrant/src/Messenger/MessageBus.php(37): Symfony\Component\Messenger\TraceableMessageBus->dispatch()#10 /vagrant/vendor/symfony/mailer/Mailer.php(66): App\Messenger\MessageBus->dispatch()#11 /vagrant/src/Mailer/Mailer.php(83): Symfony\Component\Mailer\Mailer->send()#12 /vagrant/src/Mailer/Mailer.php(96): App\Mailer\Mailer->send()#13 /vagrant/src/MessageHandler/Trading/StrategySubscriptionMessageHandler.php(118): App\Mailer\Mailer->sendEmail()#14 /vagrant/src/MessageHandler/Trading/StrategySubscriptionMessageHandler.php(72): App\MessageHandler\Trading\StrategySubscriptionMessageHandler->handle()#15 /vagrant/vendor/symfony/messenger/Middleware/HandleMessageMiddleware.php(152): App\MessageHandler\Trading\StrategySubscriptionMessageHandler->__invoke()#16 /vagrant/vendor/symfony/messenger/Middleware/HandleMessageMiddleware.php(91): Symfony\Component\Messenger\Middleware\HandleMessageMiddleware->callHandler()#17 /vagrant/vendor/symfony/messenger/Middleware/SendMessageMiddleware.php(71): Symfony\Component\Messenger\Middleware\HandleMessageMiddleware->handle()#18 /vagrant/vendor/symfony/messenger/Middleware/FailedMessageProcessingMiddleware.php(34): Symfony\Component\Messenger\Middleware\SendMessageMiddleware->handle()#19 /vagrant/vendor/symfony/messenger/Middleware/DispatchAfterCurrentBusMiddleware.php(68): Symfony\Component\Messenger\Middleware\FailedMessageProcessingMiddleware->handle()#20 /vagrant/vendor/symfony/messenger/Middleware/RejectRedeliveredMessageMiddleware.php(41): Symfony\Component\Messenger\Middleware\DispatchAfterCurrentBusMiddleware->handle()#21 /vagrant/vendor/symfony/messenger/Middleware/AddBusNameStampMiddleware.php(37): Symfony\Component\Messenger\Middleware\RejectRedeliveredMessageMiddleware->handle()#22 /vagrant/vendor/symfony/messenger/Middleware/TraceableMiddleware.php(40): Symfony\Component\Messenger\Middleware\AddBusNameStampMiddleware->handle()#23 /vagrant/vendor/symfony/messenger/MessageBus.php(70): Symfony\Component\Messenger\Middleware\TraceableMiddleware->handle()#24 /vagrant/vendor/symfony/messenger/TraceableMessageBus.php(38): Symfony\Component\Messenger\MessageBus->dispatch()#25 /vagrant/vendor/symfony/messenger/RoutableMessageBus.php(54): Symfony\Component\Messenger\TraceableMessageBus->dispatch()#26 /vagrant/vendor/symfony/messenger/Worker.php(162): Symfony\Component\Messenger\RoutableMessageBus->dispatch()#27 /vagrant/vendor/symfony/messenger/Worker.php(109): Symfony\Component\Messenger\Worker->handleMessage()#28 /vagrant/vendor/symfony/messenger/Command/ConsumeMessagesCommand.php(238): Symfony\Component\Messenger\Worker->run()#29 /vagrant/vendor/symfony/console/Command/Command.php(326): Symfony\Component\Messenger\Command\ConsumeMessagesCommand->execute()#30 /vagrant/vendor/symfony/console/Application.php(1096): Symfony\Component\Console\Command\Command->run()#31 /vagrant/vendor/symfony/framework-bundle/Console/Application.php(126): Symfony\Component\Console\Application->doRunCommand()#32 /vagrant/vendor/symfony/console/Application.php(324): Symfony\Bundle\FrameworkBundle\Console\Application->doRunCommand()#33 /vagrant/vendor/symfony/framework-bundle/Console/Application.php(80): Symfony\Component\Console\Application->doRun()#34 /vagrant/vendor/symfony/console/Application.php(175): Symfony\Bundle\FrameworkBundle\Console\Application->doRun()#35 /vagrant/vendor/symfony/runtime/Runner/Symfony/ConsoleApplicationRunner.php(49): Symfony\Component\Console\Application->run()#36 /vagrant/vendor/autoload_runtime.php(29): Symfony\Component\Runtime\Runner\Symfony\ConsoleApplicationRunner->run()#37 /vagrant/bin/console(11): require_once('...')#38 {main}```TODO:- [x] Add test for retry logic when publishing messagesCommits-------f123370 [Messenger] [Amqp] Handle AMQPConnectionException when publishing a message.
fabpot added a commit that referenced this pull requestMar 9, 2024
…ys (Brajk19)This PR was squashed before being merged into the 6.4 branch.Discussion----------[Validator] UniqueValidator - normalize before reducing keys| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues || License | MITIn#42403 checking for uniqueness of certain collection keys was enabled. Method `UniqueValidator::reduceElementKeys` removes all keys which are not specified.Problem is that this happens before normalization, which in my opinion is not great because that method accepts array argument and if i have some object (DTO), TypeError will be thrown.Example:```phpclass ParentDTO{ /** * `@var` ChildDTO[] */ #[Assert\Unique( normalizer: [ChildDTO::class, 'normalize'] fields: 'id' )] public array $children;}``````phpclass ChildDTO{ public string $id; public string $name; public static function normalize(self $obj): array { return [ 'id' => $obj->id, 'name' => $obj->name ]; }}```Because normalization will happen after `reduceElementKeys` this will be thrown:`TypeError: Symfony\Component\Validator\Constraints\UniqueValidator::reduceElementKeys(): Argument#2 ($element) must be of type array, ...\ChildDTO given, called in .../UniqueValidator.php on line 48`If `$element = $normalizer($element);` is executed before `reduceElementKeys` it would enable using Assert\Unique with array of objects when correctly normalizedCommits-------77df90b [Validator] UniqueValidator - normalize before reducing keys
nicolas-grekas added a commit that referenced this pull requestApr 12, 2024
…g similar to username/password (glaubinix)This PR was squashed before being merged into the 5.4 branch.Discussion----------[Security] Validate that CSRF token in form login is string similar to username/password| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues | See exception output below| License | MIT<!--Replace this notice by a description of your feature/bugfix.This will help reviewers and should be a good start for the documentation. - Changelog entry should followhttps://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (seehttps://symfony.com/bc).-->Fixes```Uncaught Error: Symfony\Component\Security\Http\Authenticator\Passport\Badge\CsrfTokenBadge::__construct(): Argument#2 ($csrfToken) must be of type ?string, array given, called in /vendor/symfony/security-http/Authenticator/FormLoginAuthenticator.php on line 88```Commits-------b501bba [Security] Validate that CSRF token in form login is string similar to username/password
derrabus added a commit that referenced this pull requestMay 3, 2024
…re-daubois)This PR was merged into the 5.4 branch.Discussion----------[HttpClient] Fix cURL default options for PHP 8.4| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues | -| License | MITPHP 8.4 brings a change in ext/curl (php/php-src#13291) that requires `CurlResponse` to be updated. Curl callbacks cannot be set to null anymore and requires real callable.Here is (one of) the CI error it fixes:```10) Symfony\Component\HttpClient\Tests\CurlHttpClientTest::testGzipBrokenFailed asserting that exception of type "TypeError" matches expected exception "Symfony\Contracts\HttpClient\Exception\TransportExceptionInterface". Message was: "curl_setopt_array(): Argument#2 ($options) must be a valid callback for option CURLOPT_PROGRESSFUNCTION, no array or string given" at/home/runner/work/symfony/symfony/src/Symfony/Component/HttpClient/Response/CurlResponse.php:175/home/runner/work/symfony/symfony/src/Symfony/Component/HttpClient/Internal/Canary.php:32/home/runner/work/symfony/symfony/src/Symfony/Component/HttpClient/Response/TransportResponseTrait.php:90/home/runner/work/symfony/symfony/src/Symfony/Component/HttpClient/Response/TransportResponseTrait.php:218/home/runner/work/symfony/symfony/src/Symfony/Component/HttpClient/Response/CommonResponseTrait.php:68/home/runner/work/symfony/symfony/src/Symfony/Component/HttpClient/Response/CurlResponse.php:232/home/runner/work/symfony/symfony/src/Symfony/Contracts/HttpClient/Test/HttpClientTestCase.php:1113```Commits-------cc0b957 [HttpClient] Fix cURL default options
xabbuh added a commit that referenced this pull requestAug 12, 2024
This PR was merged into the 5.4 branch.Discussion----------[Yaml] 🐛 throw ParseException on invalid date| Q | A| ------------- | ---| Branch? | 5.4 <!-- see below -->| Bug fix? | yes| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Issues | None <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->| License | MIT(found insymfony-tools/docs-builder#179)When parsing the following yaml:```date: 6418-75-51````symfony/yaml` will throw an exception:```$ php main.phpPHP Fatal error: Uncaught Exception: Failed to parse time string (6418-75-51) at position 6 (5): Unexpected character in /tmp/symfony-yaml/vendor/symfony/yaml/Inline.php:714Stack trace:#0 /tmp/symfony-yaml/vendor/symfony/yaml/Inline.php(714): DateTimeImmutable->__construct()#1 /tmp/symfony-yaml/vendor/symfony/yaml/Inline.php(312): Symfony\Component\Yaml\Inline::evaluateScalar()#2 /tmp/symfony-yaml/vendor/symfony/yaml/Inline.php(80): Symfony\Component\Yaml\Inline::parseScalar()#3 /tmp/symfony-yaml/vendor/symfony/yaml/Parser.php(790): Symfony\Component\Yaml\Inline::parse()#4 /tmp/symfony-yaml/vendor/symfony/yaml/Parser.php(341): Symfony\Component\Yaml\Parser->parseValue()#5 /tmp/symfony-yaml/vendor/symfony/yaml/Parser.php(86): Symfony\Component\Yaml\Parser->doParse()#6 /tmp/symfony-yaml/vendor/symfony/yaml/Yaml.php(77): Symfony\Component\Yaml\Parser->parse()#7 /tmp/symfony-yaml/main.php(8): Symfony\Component\Yaml\Yaml::parse()#8 {main} thrown in /tmp/symfony-yaml/vendor/symfony/yaml/Inline.php on line 714```This is because the "month" is invalid. Fixing the "month" will trigger about the same issue because the "day" would be invalid.With the current change it will throw a `ParseException`.Commits-------6d71a7e 🐛 throw ParseException on invalid date
simoheinonen added a commit to simoheinonen/symfony that referenced this pull requestOct 8, 2024
simoheinonen added a commit to simoheinonen/symfony that referenced this pull requestOct 9, 2024
nicolas-grekas added a commit that referenced this pull requestOct 9, 2024
…imoheinonen)This PR was merged into the 5.4 branch.Discussion----------[MonologBridge] Fix PHP deprecation with `preg_match()`| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues || License | MIT```preg_match(): Passing null to parameter#2 ($subject) of type string is deprecated```Commits-------4d7a6f6 Passing null to parameter#2 ($subject) of type string is deprecated
xabbuh added a commit that referenced this pull requestOct 11, 2024
* 5.4: do not mix named and positional arguments in data provider definitions session names must not be empty fix Contracts directory name in PHPUnit configuration Passing null to parameter#2 ($subject) of type string is deprecated
xabbuh added a commit that referenced this pull requestOct 11, 2024
* 6.4: do not mix named and positional arguments in data provider definitions session names must not be empty fix Contracts directory name in PHPUnit configuration Passing null to parameter#2 ($subject) of type string is deprecated
xabbuh added a commit that referenced this pull requestOct 11, 2024
* 7.1: do not mix named and positional arguments in data provider definitions session names must not be empty add missing properties fix Contracts directory name in PHPUnit configuration [Validator][CidrValidator] Fix error message for `OutOfRangeNetmask` validation Passing null to parameter#2 ($subject) of type string is deprecated
symfonyaml pushed a commit to symfonyaml/symfony that referenced this pull requestOct 21, 2024
nicolas-grekas added a commit that referenced this pull requestNov 20, 2024
…row exception (lyrixx)This PR was merged into the 5.4 branch.Discussion----------[HttpKernel] Ensure `HttpCache::getTraceKey()` does not throw exception| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues | -| License | MITWe have such logs in our logs. It's in our raw PHP logs. They are not caught by monolog, it's too early```[11-Oct-2024 01:23:33 UTC] PHP Fatal error: Uncaught Symfony\Component\HttpFoundation\Exception\SuspiciousOperationException: Invalid method override "__CONSTRUCT". in /var/www/redirection.io/backend/blue/vendor/symfony/http-foundation/Request.php:1234Stack trace:#0 /var/www/redirection.io/backend/blue/vendor/symfony/http-kernel/HttpCache/HttpCache.php(728): Symfony\Component\HttpFoundation\Request->getMethod()#1 /var/www/redirection.io/backend/blue/vendor/symfony/http-kernel/HttpCache/HttpCache.php(207): Symfony\Component\HttpKernel\HttpCache\HttpCache->getTraceKey()#2 /var/www/redirection.io/backend/blue/vendor/symfony/http-kernel/Kernel.php(188): Symfony\Component\HttpKernel\HttpCache\HttpCache->handle()#3 /var/www/redirection.io/backend/blue/web/app.php(9): Symfony\Component\HttpKernel\Kernel->handle()#4 {main} thrown in /var/www/redirection.io/backend/blue/vendor/symfony/http-foundation/Request.php on line 1234```I managed to reproduced locally.* Before the patch, without the http_cache, symfony returns a 405* After the patch, without the http_cache, symfony returns a 405* Before the patch, with the http_cache, symfony returns a 500, without any information (too early)* After the patch, with the http_cache, symfony returns a 405Commits-------a2ebbe0 [HttpKernel] Ensure HttpCache::getTraceKey() does not throw exception
stobrien89 pushed a commit to stobrien89/symfony that referenced this pull requestFeb 27, 2025
…t-dependenciesFeature/check highest and lowest dependencies
This pull request wasclosed.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.