Date pattern

Commits-------07298ac Detect EOF when reading input streamDiscussion----------[Console] Detect EOF when reading input streamThis is related to commits511a9a1 and3a5d508.First of them introduced abort-on-EOF and the second regressed the functionality.Problem is stream_get_line() doesn't return false on EOF. So it needs call to feof() todetect the situation.Still, it's not ideal. With fgets() it worked fine, but with stream_get_line() one has to pressCTRL+D twice to get out. I presume this could be bug in PHP itself.But better than nothing. Please consider.---------------------------------------------------------------------------by fabpot at 2011/07/19 22:47:53 -0700I have used `stream_get_line` especially because it does not return `false` on eof. This is needed when you pass your own stream for unit tests.---------------------------------------------------------------------------by lenar at 2011/07/25 06:05:59 -0700This is not the best solution I think. Tests should mimic and cope with real life not the other way around.Better solution would be to fix testcase. Like this:lenar/SensioGeneratorBundle@6ff3f26. Or maybe create a special "testing" stream wrapper that wraps php://memory and gives out just linefeeds after real data ends.And then change stream_get_line() back to fgets() if there is no other reason for this change.---------------------------------------------------------------------------by fabpot at 2011/07/25 06:24:20 -0700When applying your patch to the generator bundle (and revert to use `fgets`), I get "RuntimeException: Aborted" exceptions.---------------------------------------------------------------------------by lenar at 2011/07/25 06:35:08 -0700With d326f89 added +lenar/SensioGeneratorBundle@6ff3f26 I can successfully run every test in that file.---------------------------------------------------------------------------by fabpot at 2011/07/26 23:31:36 -0700@lenar: not for me. I have many 'Aborted' exception on my Mac.---------------------------------------------------------------------------by fabpot at 2011/07/26 23:41:18 -0700And I have the exact same errors on Linux:    There were 7 errors:    1) Sensio\Bundle\GeneratorBundle\Tests\Command\GenerateBundleCommandTest::testInteractiveCommand with data set #0 (array('/tmp'), 'Foo/BarBundle    ', array('Foo\\BarBundle', 'FooBarBundle', '/tmp/', 'annotation', false))    RuntimeException: Aborted    .../Symfony/Component/Console/Helper/DialogHelper.php:40    .../Symfony/Component/Console/Helper/DialogHelper.php:97    .../symfony-standard/vendor/bundles/Sensio/Bundle/GeneratorBundle/Command/GenerateBundleCommand.php:165    .../Symfony/Component/Console/Command/Command.php:205    .../Symfony/Component/Console/Tester/CommandTester.php:66    .../symfony-standard/vendor/bundles/Sensio/Bundle/GeneratorBundle/Tests/Command/GenerateBundleCommandTest.php:39    2) Sensio\Bundle\GeneratorBundle\Tests\Command\GenerateBundleCommandTest::testInteractiveCommand with data set#1 (array('/tmp'), 'Foo/BarBundle    BarBundle    foo    yml    n', array('Foo\\BarBundle', 'BarBundle', 'foo/', 'yml', false))    RuntimeException: Aborted    .../Symfony/Component/Console/Helper/DialogHelper.php:40    .../Symfony/Component/Console/Helper/DialogHelper.php:62    .../symfony-standard/vendor/bundles/Sensio/Bundle/GeneratorBundle/Command/GenerateBundleCommand.php:83    .../Symfony/Component/Console/Command/Command.php:214    .../Symfony/Component/Console/Tester/CommandTester.php:66    .../symfony-standard/vendor/bundles/Sensio/Bundle/GeneratorBundle/Tests/Command/GenerateBundleCommandTest.php:39    3) Sensio\Bundle\GeneratorBundle\Tests\Command\GenerateBundleCommandTest::testInteractiveCommand with data set#2 (array('/tmp', 'yml', 'BarBundle', true), 'Foo/BarBundle    ', array('Foo\\BarBundle', 'BarBundle', '/tmp/', 'yml', true))    RuntimeException: Aborted    .../Symfony/Component/Console/Helper/DialogHelper.php:40    .../Symfony/Component/Console/Helper/DialogHelper.php:97    .../symfony-standard/vendor/bundles/Sensio/Bundle/GeneratorBundle/Command/GenerateBundleCommand.php:165    .../Symfony/Component/Console/Command/Command.php:205    .../Symfony/Component/Console/Tester/CommandTester.php:66    .../symfony-standard/vendor/bundles/Sensio/Bundle/GeneratorBundle/Tests/Command/GenerateBundleCommandTest.php:39    4) Sensio\Bundle\GeneratorBundle\Tests\Command\GenerateDoctrineEntityCommandTest::testInteractiveCommand with data set #0 (array(), 'AcmeBlogBundle:Blog/Post    ', array('Blog\\Post', 'annotation', array()))    RuntimeException: Aborted    .../Symfony/Component/Console/Helper/DialogHelper.php:40    .../Symfony/Component/Console/Helper/DialogHelper.php:97    .../symfony-standard/vendor/bundles/Sensio/Bundle/GeneratorBundle/Command/GenerateDoctrineEntityCommand.php:145    .../Symfony/Component/Console/Command/Command.php:205    .../Symfony/Component/Console/Tester/CommandTester.php:66    .../symfony-standard/vendor/bundles/Sensio/Bundle/GeneratorBundle/Tests/Command/GenerateDoctrineEntityCommandTest.php:39    5) Sensio\Bundle\GeneratorBundle\Tests\Command\GenerateDoctrineEntityCommandTest::testInteractiveCommand with data set#1 (array('AcmeBlogBundle:Blog/Post'), '', array('Blog\\Post', 'annotation', array()))    RuntimeException: Aborted    .../Symfony/Component/Console/Helper/DialogHelper.php:40    .../Symfony/Component/Console/Helper/DialogHelper.php:97    .../symfony-standard/vendor/bundles/Sensio/Bundle/GeneratorBundle/Command/GenerateDoctrineEntityCommand.php:121    .../Symfony/Component/Console/Command/Command.php:205    .../Symfony/Component/Console/Tester/CommandTester.php:66    .../symfony-standard/vendor/bundles/Sensio/Bundle/GeneratorBundle/Tests/Command/GenerateDoctrineEntityCommandTest.php:39    6) Sensio\Bundle\GeneratorBundle\Tests\Command\GenerateDoctrineEntityCommandTest::testInteractiveCommand with data set#2 (array(), 'AcmeBlogBundle:Blog/Post    yml    ', array('Blog\\Post', 'yml', array()))    RuntimeException: Aborted    .../Symfony/Component/Console/Helper/DialogHelper.php:40    .../Symfony/Component/Console/Helper/DialogHelper.php:62    .../symfony-standard/vendor/bundles/Sensio/Bundle/GeneratorBundle/Command/GenerateDoctrineEntityCommand.php:153    .../Symfony/Component/Console/Command/Command.php:205    .../Symfony/Component/Console/Tester/CommandTester.php:66    .../symfony-standard/vendor/bundles/Sensio/Bundle/GeneratorBundle/Tests/Command/GenerateDoctrineEntityCommandTest.php:39    7) Sensio\Bundle\GeneratorBundle\Tests\Command\GenerateDoctrineEntityCommandTest::testInteractiveCommand with data set#3 (array(), 'AcmeBlogBundle:Blog/Post    yml    title    255    description    text    ', array('Blog\\Post', 'yml', array(array('title', 'string', 255), array('description', 'text'))))    RuntimeException: Aborted    .../Symfony/Component/Console/Helper/DialogHelper.php:40    .../Symfony/Component/Console/Helper/DialogHelper.php:62    .../symfony-standard/vendor/bundles/Sensio/Bundle/GeneratorBundle/Command/GenerateDoctrineEntityCommand.php:153    .../Symfony/Component/Console/Command/Command.php:205    .../Symfony/Component/Console/Tester/CommandTester.php:66    .../symfony-standard/vendor/bundles/Sensio/Bundle/GeneratorBundle/Tests/Command/GenerateDoctrineEntityCommandTest.php:39---------------------------------------------------------------------------by lenar at 2011/07/26 23:56:46 -0700@fabpot: and you modified all those tests? I only modified ```Tests/Command/GenerateDoctrineCrudCommandTest.php```and that doesn't fail as I see from your log. I just provided example, though I could add necessary changes for other tests too.---------------------------------------------------------------------------by fabpot at 2011/07/27 00:09:32 -0700@lenar: ah, sorry about that. Then, can you provide a fix for all the other tests too? Thanks a lot.---------------------------------------------------------------------------by lenar at 2011/07/27 00:22:54 -0700@fabpot: actually what do you think about this kind of fix instead for tests:lenar/SensioGeneratorBundle@517f263cb01ea2ea1ef2 instead my previous proposal (lenar/SensioGeneratorBundle@6ff3f26). Really simple, short and effective.---------------------------------------------------------------------------by fabpot at 2011/07/27 00:37:51 -0700@lenar: looks good to me. Can you create a PR?---------------------------------------------------------------------------by lenar at 2011/07/27 00:45:36 -0700@fabpot:sensiolabs/SensioGeneratorBundle#60

remove logic that could not be triggered anyway

This PR was merged into the master branch.Commits-------a146156 Merge pull request#2 from Tobion/patch-238802ea remove logic that could not be triggered anywayf7ea68f [Routing] Fixed undefined variable + typoDiscussion----------[Routing] Fixed typo + removed dead code---------------------------------------------------------------------------by Tobion at 2012-11-17T16:00:04Z@pborreli: pborreli/symfony#2---------------------------------------------------------------------------by pborreli at 2012-11-17T16:02:08Z@Tobion totally agree, tried to setup a phpunit test which could trigger this exception but couldn't ..

[WIP] some refactoring to make the ContentRouter more flexible

template must be _template

This PR was merged into the 2.3 branch.Discussion----------[2.3] Fix phpunit test suite on travis#2| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#10821| License       | MITThis is a second approach to solve#10821.Something is weird: `Symfony\Component\Form\Tests\Extension\Core\EventListener\TrimListenerTest` passes when using PHPUnit as phar and fails when using a composer global installCommits-------32e5f67 [DependencyInjection] Fix travis unit testsc7befd5 Update PHPUnit before run

This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#11998).Discussion----------[Intl] Integrated ICU data into Intl component#2| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Follow-up PR to#11920. This PR contains generated data files only.Commits-------65a8b9f [Intl] Generated the data for ICU version 54-rc

This PR was merged into the 2.6-dev branch.Discussion----------[VarDumper] Dynamic HTML dumper| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#12109| License       | MIT| Doc PR        | -This PR partially reverts#12109 because it didn't take into account that many dumps can share a single style tag.More importantly, this PR enhance dump rendering with some cute JS navigation effects:- references highlighting on hovering- moving references togglingHere is a screenshot (note the yellow background and the fact that `#2` appears after the first `@2`):![capture du 2014-10-04 09 45 44](https://cloud.githubusercontent.com/assets/243674/4514936/4431c67e-4b9b-11e4-9809-8d06836be824.png)Commits-------b799844 [VarDumper] Dynamic HTML dumper

This PR was submitted for the master branch but it was merged into the 2.5 branch instead (closes#12453).Discussion----------[Debug] Show only unique class candidates| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -```PHPUnit 4.3.5 by Sebastian Bergmann.Configuration read from .../symfony/phpunit.xml.distS....S.............................FFFS.......Time: 2.29 seconds, Memory: 8.50MbThere were 3 failures:1) Symfony\Component\Debug\Tests\FatalErrorHandler\ClassNotFoundFatalErrorHandlerTest::testClassNotFound with data set#2 (array(1, 12, 'foo.php', 'Class \'UndefinedFunctionException\' not found'), 'Attempted to load class "UndefinedFunctionException" from the global namespace.Did you forget a "use" statement for "Symfony\\Component\\Debug\\Exception\\UndefinedFunctionException"?')Failed asserting that two strings are identical.--- Expected+++ Actual@@ @@ Attempted to load class "UndefinedFunctionException" from the global namespace.-Did you forget a "use" statement for "Symfony\Component\Debug\Exception\UndefinedFunctionException"?+Did you forget a "use" statement for e.g. "Symfony\Component\Debug\Exception\UndefinedFunctionException" or "Symfony\Component\Debug\Exception\UndefinedFunctionException"?.../symfony/src/Symfony/Component/Debug/Tests/FatalErrorHandler/ClassNotFoundFatalErrorHandlerTest.php:282) Symfony\Component\Debug\Tests\FatalErrorHandler\ClassNotFoundFatalErrorHandlerTest::testClassNotFound with data set#3 (array(1, 12, 'foo.php', 'Class \'PEARClass\' not found'), 'Attempted to load class "PEARClass" from the global namespace.Did you forget a "use" statement for "Symfony_Component_Debug_Tests_Fixtures_PEARClass"?')Failed asserting that two strings are identical.--- Expected+++ Actual@@ @@ Attempted to load class "PEARClass" from the global namespace.-Did you forget a "use" statement for "Symfony_Component_Debug_Tests_Fixtures_PEARClass"?+Did you forget a "use" statement for e.g. "Symfony_Component_Debug_Tests_Fixtures_PEARClass" or "Symfony_Component_Debug_Tests_Fixtures_PEARClass"?.../symfony/src/Symfony/Component/Debug/Tests/FatalErrorHandler/ClassNotFoundFatalErrorHandlerTest.php:283) Symfony\Component\Debug\Tests\FatalErrorHandler\ClassNotFoundFatalErrorHandlerTest::testClassNotFound with data set#4 (array(1, 12, 'foo.php', 'Class \'Foo\\Bar\\UndefinedFunctionException\' not found'), 'Attempted to load class "UndefinedFunctionException" from namespace "Foo\\Bar".Did you forget a "use" statement for "Symfony\\Component\\Debug\\Exception\\UndefinedFunctionException"?')Failed asserting that two strings are identical.--- Expected+++ Actual@@ @@ Attempted to load class "UndefinedFunctionException" from namespace "Foo\Bar".-Did you forget a "use" statement for "Symfony\Component\Debug\Exception\UndefinedFunctionException"?+Did you forget a "use" statement for e.g. "Symfony\Component\Debug\Exception\UndefinedFunctionException" or "Symfony\Component\Debug\Exception\UndefinedFunctionException"?.../symfony/src/Symfony/Component/Debug/Tests/FatalErrorHandler/ClassNotFoundFatalErrorHandlerTest.php:28```Commits-------db8a3ae [Debug] Show only unique class candidates

Add comment as requested - see comment for stof

…re-daubois)This PR was merged into the 5.4 branch.Discussion----------[HttpClient] Fix cURL default options for PHP 8.4| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        | -| License       | MITPHP 8.4 brings a change in ext/curl (php/php-src#13291) that requires `CurlResponse` to be updated. Curl callbacks cannot be set to null anymore and requires real callable.Here is (one of) the CI error it fixes:```10) Symfony\Component\HttpClient\Tests\CurlHttpClientTest::testGzipBrokenFailed asserting that exception of type "TypeError" matches expected exception "Symfony\Contracts\HttpClient\Exception\TransportExceptionInterface". Message was: "curl_setopt_array(): Argument#2 ($options) must be a valid callback for option CURLOPT_PROGRESSFUNCTION, no array or string given" at/home/runner/work/symfony/symfony/src/Symfony/Component/HttpClient/Response/CurlResponse.php:175/home/runner/work/symfony/symfony/src/Symfony/Component/HttpClient/Internal/Canary.php:32/home/runner/work/symfony/symfony/src/Symfony/Component/HttpClient/Response/TransportResponseTrait.php:90/home/runner/work/symfony/symfony/src/Symfony/Component/HttpClient/Response/TransportResponseTrait.php:218/home/runner/work/symfony/symfony/src/Symfony/Component/HttpClient/Response/CommonResponseTrait.php:68/home/runner/work/symfony/symfony/src/Symfony/Component/HttpClient/Response/CurlResponse.php:232/home/runner/work/symfony/symfony/src/Symfony/Contracts/HttpClient/Test/HttpClientTestCase.php:1113```Commits-------cc0b957 [HttpClient] Fix cURL default options

This PR was merged into the 5.4 branch.Discussion----------[Yaml] 🐛 throw ParseException on invalid date| Q             | A| ------------- | ---| Branch?       | 5.4 <!-- see below -->| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Issues        | None <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->| License       | MIT(found insymfony-tools/docs-builder#179)When parsing the following yaml:```date: 6418-75-51````symfony/yaml` will throw an exception:```$ php main.phpPHP Fatal error:  Uncaught Exception: Failed to parse time string (6418-75-51) at position 6 (5): Unexpected character in /tmp/symfony-yaml/vendor/symfony/yaml/Inline.php:714Stack trace:#0 /tmp/symfony-yaml/vendor/symfony/yaml/Inline.php(714): DateTimeImmutable->__construct()#1 /tmp/symfony-yaml/vendor/symfony/yaml/Inline.php(312): Symfony\Component\Yaml\Inline::evaluateScalar()#2 /tmp/symfony-yaml/vendor/symfony/yaml/Inline.php(80): Symfony\Component\Yaml\Inline::parseScalar()#3 /tmp/symfony-yaml/vendor/symfony/yaml/Parser.php(790): Symfony\Component\Yaml\Inline::parse()#4 /tmp/symfony-yaml/vendor/symfony/yaml/Parser.php(341): Symfony\Component\Yaml\Parser->parseValue()#5 /tmp/symfony-yaml/vendor/symfony/yaml/Parser.php(86): Symfony\Component\Yaml\Parser->doParse()#6 /tmp/symfony-yaml/vendor/symfony/yaml/Yaml.php(77): Symfony\Component\Yaml\Parser->parse()#7 /tmp/symfony-yaml/main.php(8): Symfony\Component\Yaml\Yaml::parse()#8 {main}  thrown in /tmp/symfony-yaml/vendor/symfony/yaml/Inline.php on line 714```This is because the "month" is invalid. Fixing the "month" will trigger about the same issue because the "day" would be invalid.With the current change it will throw a `ParseException`.Commits-------6d71a7e 🐛 throw ParseException on invalid date

…ecated

…ecated

…imoheinonen)This PR was merged into the 5.4 branch.Discussion----------[MonologBridge] Fix PHP deprecation with `preg_match()`| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        || License       | MIT```preg_match(): Passing null to parameter#2 ($subject) of type string is deprecated```Commits-------4d7a6f6 Passing null to parameter#2 ($subject) of type string is deprecated

* 5.4:  do not mix named and positional arguments in data provider definitions  session names must not be empty  fix Contracts directory name in PHPUnit configuration  Passing null to parameter#2 ($subject) of type string is deprecated

* 6.4:  do not mix named and positional arguments in data provider definitions  session names must not be empty  fix Contracts directory name in PHPUnit configuration  Passing null to parameter#2 ($subject) of type string is deprecated

* 7.1:  do not mix named and positional arguments in data provider definitions  session names must not be empty  add missing properties  fix Contracts directory name in PHPUnit configuration  [Validator][CidrValidator] Fix error message for `OutOfRangeNetmask` validation  Passing null to parameter#2 ($subject) of type string is deprecated

…ecated

…row exception (lyrixx)This PR was merged into the 5.4 branch.Discussion----------[HttpKernel] Ensure `HttpCache::getTraceKey()` does not throw exception| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        | -| License       | MITWe have such logs in our logs. It's in our raw PHP logs. They are not caught by monolog, it's too early```[11-Oct-2024 01:23:33 UTC] PHP Fatal error:  Uncaught Symfony\Component\HttpFoundation\Exception\SuspiciousOperationException: Invalid method override "__CONSTRUCT". in /var/www/redirection.io/backend/blue/vendor/symfony/http-foundation/Request.php:1234Stack trace:#0 /var/www/redirection.io/backend/blue/vendor/symfony/http-kernel/HttpCache/HttpCache.php(728): Symfony\Component\HttpFoundation\Request->getMethod()#1 /var/www/redirection.io/backend/blue/vendor/symfony/http-kernel/HttpCache/HttpCache.php(207): Symfony\Component\HttpKernel\HttpCache\HttpCache->getTraceKey()#2 /var/www/redirection.io/backend/blue/vendor/symfony/http-kernel/Kernel.php(188): Symfony\Component\HttpKernel\HttpCache\HttpCache->handle()#3 /var/www/redirection.io/backend/blue/web/app.php(9): Symfony\Component\HttpKernel\Kernel->handle()#4 {main}  thrown in /var/www/redirection.io/backend/blue/vendor/symfony/http-foundation/Request.php on line 1234```I managed to reproduced locally.* Before the patch, without the http_cache, symfony returns a 405* After the patch, without the http_cache, symfony returns a 405* Before the patch, with the http_cache, symfony returns a 500, without any information (too early)* After the patch, with the http_cache, symfony returns a 405Commits-------a2ebbe0 [HttpKernel] Ensure HttpCache::getTraceKey() does not throw exception

…t-dependenciesFeature/check highest and lowest dependencies

…operty when not on source (#2)

…ka, rvanlaak)This PR was merged into the 7.3 branch.Discussion----------[ObjectMapper] read source metadata before transform| Q             | A| ------------- | ---| Branch?       | 7.3| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        |fixes#61027| License       | MITCommits-------c1e4adf [ObjectMapper] do not require mapping a target's required promoted property when not on source (#2)50e177d [ObjectMapper] read source metadata before transform

* 7.3:  [ObjectMapper] do not require mapping a target's required promoted property when not on source (#2)  [GitHub] Update .github/PULL_REQUEST_TEMPLATE.md to remove SF 7.2 as it's not supported anymore  [WebProfilerBundle] Fix toolbar not rendering after replacing it  Add friendly name in the `to` field  [ObjectMapper] read source metadata before transform  [HtmlSanitizer] Fix force_attributes not replacing existing attribute in initial data

* 7.4:  [ObjectMapper] do not require mapping a target's required promoted property when not on source (#2)  run tests with PHPUnit 12.3  [GitHub] Update .github/PULL_REQUEST_TEMPLATE.md to remove SF 7.2 as it's not supported anymore  [CI] fixed the Intl data tests actions Tests fails due to unknown option -v which is shorthand of the --verbose as per the phpunit its removed without any replacementsebastianbergmann/phpunit#5647 (comment)  [Mailer] Fix expected exception message to include quotes around "http(s)://"  [WebProfilerBundle] Fix toolbar not rendering after replacing it  [Validator] (60455) Validate translations for Arabic (ar)  (60474) Remove translation state attribute for Twig template validator in Ukrainian translation  [VarDumper] Fix dumping objects from the DOM extension  [Mailer] Add MicrosoftGraph API Transport  [Yaml] Fix code style  [Tests] Adapt testAddHtmlContentWithErrors to be HTML5 compliant  Add friendly name in the `to` field  [ObjectMapper] read source metadata before transform  [HtmlSanitizer] Fix force_attributes not replacing existing attribute in initial data