Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
inlined some CSS#19997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
inlined some CSS#19997
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fabpot commentedSep 20, 2016
If you are wondering why we did not cleanup this before, that's because those CSSes were shared between the web profiler and the twig exception files, but that's not the case anymore since the redesign of the web profiler. |
| <linkhref="{{ absolute_url(asset('bundles/framework/css/exception.css')) }}"rel="stylesheet"type="text/css"media="all" /> | ||
| <style> | ||
| .sf-reset.traces { | ||
| padding-bottom:14px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
is it better use separate css file and include it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What would be the benefit? It means adding a controller to handle it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we do same for svg icons inlining without controller (use twig include):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I agree, this is indeed what is done elsewhere, but here, I don't want to "pollute" the namespace as there are only exceptions templates, and creating a new directory up sounds like not really useful.
nicolas-grekas commentedSep 21, 2016
👍 |
cfbaa08 tof354638Comparefabpot commentedSep 21, 2016
added the change to the CHANGELOG file |
This PR was merged into the 3.2-dev branch.Discussion----------inlined some CSS| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aThis PR has several goals:* It fixes the discrepancy between where CSS files were stored (FrameworkBundle) and where there were used (TwigBundle);* It removes the need to install the assets to get exceptions (think Silex, micro-kernel-based-edition, ...);* It makes things consistent with how we already manage images for exceptions (they are inlined);* It makes things consistent with how we manage assets for the web profiler.Commits-------f354638 inlined some CSS
This PR has several goals: