Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[VarDumper] Use ClassStub for reflected types#19987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromnicolas-grekas:dump-fix
Sep 21, 2016

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekasnicolas-grekas commentedSep 20, 2016•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

The implementation ensures that type hints do not trigger autoloading byClassStub itself.

@jakzal
Copy link
Contributor

It doesn't seem to fix theSecurityBundle tests (should it?).

@nicolas-grekas
Copy link
MemberAuthor

nicolas-grekas commentedSep 20, 2016•
edited
Loading

@jakzal this is because of per-component tests: the patch here is not used on the SecurityBundle test suite because SecurityBundle is untouched by the PR. This a corner case. But as far as I tested correctly on my machine, it will make tests green yes.

@nicolas-grekas
Copy link
MemberAuthor

Oh, and the PR that should fix tests is#19986, not this one :)

@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commite2b2c9b intosymfony:masterSep 21, 2016
fabpot added a commit that referenced this pull requestSep 21, 2016
…-grekas)This PR was merged into the 3.2-dev branch.Discussion----------[VarDumper] Use ClassStub for reflected types| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -The implementation ensures that type hints do not trigger autoloading by `ClassStub` itself.Commits-------e2b2c9b [VarDumper] Use ClassStub for reflected types
@nicolas-grekasnicolas-grekas deleted the dump-fix branchSeptember 29, 2016 10:06
@fabpotfabpot mentioned this pull requestOct 27, 2016
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolas-grekas@jakzal@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp