Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[TwigBridge] removed Twig null nodes (deprecated as of Twig 1.25)#19983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
fabpot commentedSep 19, 2016
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes (more about removing deprecation notices from newer versions of Twig) |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a (seetwigphp/Twig#2123) |
| License | MIT |
| Doc PR | n/a |
fabpot added a commit that referenced this pull requestSep 19, 2016
…g 1.25) (fabpot)This PR was merged into the 2.7 branch.Discussion----------[TwigBridge] removed Twig null nodes (deprecated as of Twig 1.25)| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes (more about removing deprecation notices from newer versions of Twig)| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a (seetwigphp/Twig#2123)| License | MIT| Doc PR | n/aCommits-------12350c2 [TwigBridge] removed Twig null nodes (deprecated as of Twig 1.25)
This was referencedOct 3, 2016
Merged
Merged
Merged
arthens added a commit to arthens/safe-translations that referenced this pull requestOct 28, 2016
The current implementation of the parser relies on being able to callnode.getNode(...) for null node too. However, null nodes are deprecatedas of Twig 1.25 and twig-bridge throws an exception when trying to reada null node, seesymfony/symfony#19983This change fixes the problem by checking if the node exits beforegetting it
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.