Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Support autowiring for RouterInterface#19972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
hason wants to merge1 commit intosymfony:masterfromhason-contributions:aw_router

Conversation

@hason
Copy link
Contributor

@hasonhason commentedSep 19, 2016•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

Copy link
Contributor

@lemoinemlemoinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi there, Thanks for the contribution.

Why use a new CompilerPass instead of simply adding the configuration at the definition of the router service inResources/config/routing.xml?

@nicolas-grekasnicolas-grekas added this to the3.x milestoneDec 6, 2016
@nicolas-grekas
Copy link
Member

Needs to be updated to account for#21494
Looks like this now just needs a few aliases inResources/config/routing.xml.

Status: needs work

@nicolas-grekas
Copy link
Member

Closing, please submit a new PR using aliases if you'd like.

@nicolas-grekasnicolas-grekas modified the milestones:3.x,3.3Mar 24, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@lemoinemlemoinemlemoinem left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

4 participants

@hason@nicolas-grekas@lemoinem@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp