NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Validator] Allow Choice Constraint Callback to be non-static#19959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

patrick-mcdougle wants to merge1 commit intosymfony:masterfrompatrick-mcdougle:pmcd-choice-validator-feature

Closed

[Validator] Allow Choice Constraint Callback to be non-static#19959

patrick-mcdougle wants to merge1 commit intosymfony:masterfrompatrick-mcdougle:pmcd-choice-validator-feature

Conversation

Copy link

Contributor

patrick-mcdougle commentedSep 17, 2016

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	none
License	MIT
Doc PR	will write if community wants this feature

Now that as of 3.0 the ExecutionContextInterface has a getObject method, the callback doesn't need to be static anymore, it can actually be on the object that's being validated. This is great because you can actually have dynamic choices and this validator will actually work. Maintainers are free to add commits to this branch.