Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Console] Exclude empty namespaces in text descriptor#19954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromro0NL:console/command-aliases
Mar 22, 2017
Merged

[Console] Exclude empty namespaces in text descriptor#19954

fabpot merged 1 commit intosymfony:masterfromro0NL:console/command-aliases
Mar 22, 2017

Conversation

@ro0NL
Copy link
Contributor

@ro0NLro0NL commentedSep 17, 2016
edited
Loading

QA
Branch?"master"
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketscomma-separated list of tickets fixed by the PR, if any
LicenseMIT
Doc PRreference to the documentation PR, if any

Before:

$ bin/console doctrine  doctrine:mapping:convert                [orm:convert:mapping] Convert mapping information between supported formats. orm <---- router  router:match                            Helps debug routes by simulating a path info match$ bin/console list orm  [Symfony\Component\Debug\Exception\ContextErrorException]    Warning: max(): Array must contain at least one element  $ bin/console list generateAvailable commands for the "generate" namespace:  generate:bundle      Generates a bundle  generate:command     Generates a console command  generate:controller  Generates a controller

After:

$ bin/console doctrine  doctrine:mapping:convert                [orm:convert:mapping] Convert mapping information between supported formats. router  router:match                            Helps debug routes by simulating a path info match$ bin/console list ormAvailable commands for the "orm" namespace:  orm:convert:mapping  Convert mapping information between supported formats.$ bin/console list generateAvailable commands for the "generate" namespace:  generate:bundle             Generates a bundle  generate:command            Generates a console command  generate:controller         Generates a controller  generate:doctrine:crud      Generates a CRUD based on a Doctrine entity  generate:doctrine:entities  Generates entity classes and method stubs from your mapping information  generate:doctrine:entity    Generates a new Doctrine entity inside a bundle  generate:doctrine:form      Generates a form type class based on a Doctrine entity

Overrules#19776 but also includes other fixes related to aliases that popped up when writing tests 👍

azatyan reacted with thumbs up emoji
@ro0NLro0NL changed the title[Console] Include alias commands in text descriptor[Console] Exlude empty namespaces in text descriptorSep 17, 2016
@ro0NLro0NL changed the title[Console] Exlude empty namespaces in text descriptor[Console] Exclude empty namespaces in text descriptorSep 17, 2016
@fabpot
Copy link
Member

Can you add a unit test to avoid regressions? Thanks.

<comment>Available commands:</comment>
<info>help</info> Displays help for a command
<info>list</info> Lists commands
<info>help</info>Displays help for a command
Copy link
ContributorAuthor

@ro0NLro0NLSep 17, 2016
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

getColumnWidth considers aliases (descriptor:alias_command3), but we explicitly not render those.. not sure how to solve it..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can't you have the same logic in getColumnWidth to have the same "exclusion rules"?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fixed.

@ro0NL
Copy link
ContributorAuthor

@fabpot maybe72374eb should target 2.7 to ease future upstream merges/diffs...

@fabpot
Copy link
Member

Indeed, merging it in 2.7 would greatly help

@ro0NL
Copy link
ContributorAuthor

ro0NL commentedSep 17, 2016
edited
Loading

Would a PR do? Can you also please have a look at#19776 and decide what to do? I'd prefer this PR as a whole (all fixes can target master).

parent::__construct('My Symfony application','v1.0');
$this->add(newDescriptorCommand1());
$this->add(newDescriptorCommand2());
$this->add(newDescriptorCommand3());
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

For the record, i chose this approach on testing to include the case in other formats as well (Markdown, XML, etc.). This to avoid future regressions as well.

@fabpot
Copy link
Member

Can you rebase on current master?

@ro0NL
Copy link
ContributorAuthor

Done.

@javiereguiluzjaviereguiluz added this to the3.2 milestoneNov 7, 2016
@fabpotfabpot removed this from the3.2 milestoneNov 16, 2016
@nicolas-grekasnicolas-grekas added this to the3.x milestoneDec 6, 2016
@fabpot
Copy link
Member

@ro0NL Sorry about that but can you rebase one last time? When done, ping me so that I can merge ASAP to avoid any problems. Thanks.

@ro0NL
Copy link
ContributorAuthor

ro0NL commentedMar 22, 2017
edited
Loading

@fabpot done. Replayed the before/after scenarios once more, and still all good. Waiting for travis though :)

edit: green :)

@fabpot
Copy link
Member

Thank you@ro0NL.

@fabpotfabpot merged commitd5a7608 intosymfony:masterMar 22, 2017
fabpot added a commit that referenced this pull requestMar 22, 2017
…(ro0NL)This PR was merged into the 3.3-dev branch.Discussion----------[Console] Exclude empty namespaces in text descriptor| Q | A || --- | --- || Branch? | "master" || Bug fix? | yes || New feature? | no || BC breaks? | no || Deprecations? | no || Tests pass? | yes || Fixed tickets | comma-separated list of tickets fixed by the PR, if any || License | MIT || Doc PR | reference to the documentation PR, if any |Before:```$ bin/console doctrine  doctrine:mapping:convert                [orm:convert:mapping] Convert mapping information between supported formats. orm <---- router  router:match                            Helps debug routes by simulating a path info match$ bin/console list orm  [Symfony\Component\Debug\Exception\ContextErrorException]  Warning: max(): Array must contain at least one element$ bin/console list generateAvailable commands for the "generate" namespace:  generate:bundle      Generates a bundle  generate:command     Generates a console command  generate:controller  Generates a controller```After:```$ bin/console doctrine  doctrine:mapping:convert                [orm:convert:mapping] Convert mapping information between supported formats. router  router:match                            Helps debug routes by simulating a path info match$ bin/console list ormAvailable commands for the "orm" namespace:  orm:convert:mapping  Convert mapping information between supported formats.$ bin/console list generateAvailable commands for the "generate" namespace:  generate:bundle             Generates a bundle  generate:command            Generates a console command  generate:controller         Generates a controller  generate:doctrine:crud      Generates a CRUD based on a Doctrine entity  generate:doctrine:entities  Generates entity classes and method stubs from your mapping information  generate:doctrine:entity    Generates a new Doctrine entity inside a bundle  generate:doctrine:form      Generates a form type class based on a Doctrine entity```Overrules#19776 but also includes other fixes related to aliases that popped up when writing tests 👍Commits-------d5a7608 [Console] Exclude empty namespaces in text descriptor
@ro0NLro0NL deleted the console/command-aliases branchMarch 22, 2017 18:52
@nicolas-grekasnicolas-grekas modified the milestones:3.x,3.3Mar 24, 2017
@fabpotfabpot mentioned this pull requestMay 1, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot left review comments

Assignees

No one assigned

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

4 participants

@ro0NL@fabpot@javiereguiluz@nicolas-grekas

[8]ページ先頭

©2009-2025 Movatter.jp