Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Parse source link maps using json_decode() instead of parse_str()#19950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
jeremyFreeAgent commentedSep 16, 2016
Thanks! |
nicolas-grekas added a commit that referenced this pull requestSep 16, 2016
…() instead of parse_str() (nicolas-grekas)This PR was merged into the 3.2-dev branch.Discussion----------[FrameworkBundle] Parse source link maps using json_decode() instead of parse_str()| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | updated code exists only on master| Deprecations? | no| Tests pass? | yes| Fixed tickets |#19807| License | MIT| Doc PR |symfony/symfony-docs#6944Because `parse_str()` turns some characters into underscores in keys (e.g. `.`).Commits-------9b174fb [FrameworkBundle] Parse source link maps using json_decode() instead of parse_str()
fabpot added a commit that referenced this pull requestOct 5, 2016
…ile_link_format (nicolas-grekas)This PR was merged into the 3.2-dev branch.Discussion----------Simplified link-to-source mapping definitions in debug.file_link_format| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#19950| License | MIT| Doc PR |symfony/symfony-docs#7019Having to json_encode here (or any other kind of encoding) is really tedious to deal with: it makes it hard to have things working quickly. `%f` and `%l` aren't encoded anyway, so let's use very unlikely chars as separators here also instead.Commits-------27df38e Simplified link-to-source mapping definitions in debug.file_link_format
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
parse_str()turns some characters into underscores in keys (e.g..).