Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Fix TranslationUpdateCommand tests after a merge#19926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@jakzal
Copy link
Contributor

QA
Branch?master
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#19921
LicenseMIT
Doc PR-
#19325 relied on a wrong count of messages, which was fixed by#19878.

Additionally, thegetContainer() method on the master branch expect messages to be indexed by domain.

@nicolas-grekas
Copy link
Member

So, only an issue in tests? Shouldn't this be applied on previous branches? Any potential BC break spotted by this failure?

@jakzal
Copy link
ContributorAuthor

Not sure why PHP 7 builds are failing here:

Could not load package symfony/framework-bundle in file:///home/travis/build/symfony/symfony: [UnexpectedValueException] Invalid version string "master.999"

@jakzal
Copy link
ContributorAuthor

So, only an issue in tests? Shouldn't this be applied on previous branches? Any potential BC break spotted by this failure?

Yes, only issue with tests. It's a result of changes made on master.

#19325 relied on a wrong count of messages, which was fixed by#19878.

The#19325 test is only present in the master branch, so it wasn't a problem until#19878 was merged to master.

Additionally, the getContainer() method on the master branch expect messages to be indexed by domain.

Again, this is only on master.

nicolas-grekas reacted with thumbs up emoji

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedSep 13, 2016•
edited
Loading

Could not load package symfony/framework-bundle

I'll look at this asap, should be related to the changes I made yesterday, that were far from easy :)

@nicolas-grekas
Copy link
Member

Thank you@jakzal.

@nicolas-grekasnicolas-grekas merged commitd093c40 intosymfony:masterSep 13, 2016
nicolas-grekas added a commit that referenced this pull requestSep 13, 2016
… a merge (jakzal)This PR was merged into the 3.2-dev branch.Discussion----------[FrameworkBundle] Fix TranslationUpdateCommand tests after a merge| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#19921| License       | MIT| Doc PR        | -#19325 relied on a wrong count of messages, which was fixed by#19878.Additionally, the `getContainer()` method on the master branch expect messages to be indexed by domain.Commits-------d093c40 [FrameworkBundle] Fix TranslationUpdateCommand tests after a merge
@jakzaljakzal deleted the translation-update-tests-fix branchSeptember 13, 2016 12:03
@fabpotfabpot mentioned this pull requestOct 27, 2016
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jakzal@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp