Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[bugfix] [Console] SetInput::$interactive tofalse when command is executed with--quiet as verbosity level#19923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…is executed with `--quiet` as verbosity level
fabpot commentedSep 14, 2016
I don't understand why quiet and interactive would be tied. I made this decoupling consciously back then. It looks more flexible. So, I'm 👎 for this change. |
phansys commentedSep 14, 2016
I understand your concern about the responsibilities, but the fact I'm exposing here is that isn't possible to interact with a command when it is executed in quiet mode, given the command isn't able to prompt for any input or provide any kind of response to the user. For this reason, I think a method called |
fabpot commentedSep 14, 2016
Ah, understood now. Indeed, if even the questions are not displayed, that does not really make sense to have an interactive quiet command :) |
fabpot commentedSep 14, 2016
Thank you@phansys. |
…en command is executed with `--quiet` as verbosity level (phansys)This PR was merged into the 2.7 branch.Discussion----------[bugfix] [Console] Set `Input::$interactive` to `false` when command is executed with `--quiet` as verbosity level|Q |A ||--- |--- ||Branch |2.7 ||Bug fix? |yes ||New feature? |no ||BC breaks? |yes ||Deprecations?|no ||Tests pass? |yes ||Fixed tickets|#19899||License |MIT ||Doc PR |n/a |Closes#19899.Commits-------4214311 [bugfix] [Console] Set `Input::$interactive` to `false` when command is executed with `--quiet` as verbosity level
Uh oh!
There was an error while loading.Please reload this page.
Closes#19899.