Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[bugfix] [Console] SetInput::$interactive tofalse when command is executed with--quiet as verbosity level#19923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:2.7fromphansys:ticket_19899
Sep 14, 2016

Conversation

@phansys
Copy link
Contributor

@phansysphansys commentedSep 13, 2016
edited
Loading

QA
Branch2.7
Bug fix?yes
New feature?no
BC breaks?yes
Deprecations?no
Tests pass?yes
Fixed tickets#19899
LicenseMIT
Doc PRn/a

Closes#19899.

…is executed with `--quiet` as verbosity level
@fabpot
Copy link
Member

I don't understand why quiet and interactive would be tied. I made this decoupling consciously back then. It looks more flexible. So, I'm 👎 for this change.

@phansys
Copy link
ContributorAuthor

I understand your concern about the responsibilities, but the fact I'm exposing here is that isn't possible to interact with a command when it is executed in quiet mode, given the command isn't able to prompt for any input or provide any kind of response to the user. For this reason, I think a method calledisInteractive() must returnfalse when the command isn't allowed to interact with the user at all.

@fabpot
Copy link
Member

Ah, understood now. Indeed, if even the questions are not displayed, that does not really make sense to have an interactive quiet command :)

phansys reacted with thumbs up emoji

@fabpot
Copy link
Member

Thank you@phansys.

@fabpotfabpot merged commit4214311 intosymfony:2.7Sep 14, 2016
fabpot added a commit that referenced this pull requestSep 14, 2016
…en command is executed with `--quiet` as verbosity level (phansys)This PR was merged into the 2.7 branch.Discussion----------[bugfix] [Console] Set `Input::$interactive` to `false` when command is executed with `--quiet` as verbosity level|Q            |A     ||---          |---   ||Branch       |2.7   ||Bug fix?     |yes   ||New feature? |no    ||BC breaks?   |yes    ||Deprecations?|no    ||Tests pass?  |yes   ||Fixed tickets|#19899||License      |MIT   ||Doc PR       |n/a   |Closes#19899.Commits-------4214311 [bugfix] [Console] Set `Input::$interactive` to `false` when command is executed with `--quiet` as verbosity level
@phansysphansys deleted the ticket_19899 branchSeptember 14, 2016 20:29
This was referencedOct 3, 2016
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phansys@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp