Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Yaml] Add bin/lint for using the LintCommand#19916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fabpot commentedSep 12, 2016
I think I'm slightly 👎 on adding a script here. This is a component, so it gives you building blocks that you can assemble the way you want. What others think? ping @symfony/deciders |
chalasr commentedSep 12, 2016
I think you're right, adding such example to the documentation should be enough for the use case. |
fabpot commentedSep 12, 2016
@chalasr Can you submit a doc PR then? That sounds indeed very useful to have this in the docs. |
chalasr commentedSep 12, 2016
…luz)This PR was submitted for the master branch but it was merged into the 3.2 branch instead (closes#6963).Discussion----------[Yaml] Add lint:yaml command usageThis documentssymfony/symfony#19139 (merged on 3.2) andclosessymfony/symfony#19916.Commits-------ed4cb40 Remove an unneeded code directive44b4ad0 Use `terminal` instead of `bash` for console code78075c1 Yaml] Add lint:yaml command usage
In#19139 we moved the
lint:yamlcommand from the FrameworkBundle to the Yaml component.The usage did not change in the framework, the old command became a child of the Yaml one.
But now, using this command in the standalone Yaml requires to create an application. Here I propose to provide the application as an executable, so that the command is really usable directly when installing the yaml+console components as dependencies.
I may be wrong when I think it's worth it but to me, moving the command to the yaml component doesn't fully make sense if it cannot be used directly outside of the full stack framework.