Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Bridge/PhpUnit] Add bin/simple-phpunit wrapper (=phpunit - yaml - prophecy)#19915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
b9fa27a to37c18f1Compare.travis.yml Outdated
| cache: | ||
| directories: | ||
| -.phpunit | ||
| -vendor/symfony/phpunit-bridge/bin/.phpunit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Isn't it an "issue" that we write in the vendor directory? I'm pretty sure that we never write under vendor anywhere else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
updated: this is still the default because I don't see any better one, but one can overwrite it with theSYMFONY_PHPUNIT_DIR env var now.
17e81a1 to966a55dComparefabpot commentedSep 12, 2016
I think we need to add some docs to the README about its usage and the env vars that one can define. |
nicolas-grekas commentedSep 12, 2016
Doc PR added, tests green. |
966a55d to0c1c70cComparenicolas-grekas commentedSep 12, 2016
Needs#19917 to be green (and reciprocally) |
fabpot commentedSep 12, 2016
Thank you@nicolas-grekas. |
…nit - yaml - prophecy) (nicolas-grekas)This PR was merged into the 3.2-dev branch.Discussion----------[Bridge/PhpUnit] Add bin/simple-phpunit wrapper (=phpunit - yaml - prophecy)| Q | A| ------------- | ---| Branch? | master| New feature? | yes| Tests pass? | not yet| License | MIT| Doc PR |symfony/symfony-docs#6962So that e.g. [Sami](https://github.com/FriendsOfPHP/Sami/blob/master/phpunit) & [SensioFranmeworkExtraBundle](https://github.com/sensiolabs/SensioFrameworkExtraBundle/blob/master/phpunit) can stop copy/pasting our phpunit wrapper and get it from phpunit-bridge instead.2 commits to keep the "rename" semantic in the git history.Diff best viewed by looking directly at each commit.Commits-------0c1c70c [Bridge/PhpUnit] Add bin/simple-phpunit wrapper (=phpunit - yaml - prophecy)
…, weaverryan)This PR was merged into the master branch.Discussion----------[Bridge/PhpUnit] doc bin/simple-phpunitSeesymfony/symfony#19915Commits-------c600921 Making changes thanks to Javier!46825ab [Bridge/PhpUnit] doc bin/simple-phpunit
Uh oh!
There was an error while loading.Please reload this page.
So that e.g.Sami &SensioFranmeworkExtraBundle can stop copy/pasting our phpunit wrapper and get it from phpunit-bridge instead.
2 commits to keep the "rename" semantic in the git history.
Diff best viewed by looking directly at each commit.