Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Workflow] Make PropertyAccess required dependency#19849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromOndraM:workflow-requirements
Sep 5, 2016
Merged

[Workflow] Make PropertyAccess required dependency#19849

fabpot merged 1 commit intosymfony:masterfromOndraM:workflow-requirements
Sep 5, 2016

Conversation

@OndraM
Copy link
Contributor

@OndraMOndraM commentedSep 4, 2016•
edited
Loading

QA
Branch?master (3.2 is not yet released)
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?N/A
Fixed ticketsN/A
LicenseMIT
Doc PRN/A

Hi, when using Workflow as a standalone component (and instantiating newWorkflow() instance), I'm getting errors like:

PHP Fatal error:  Class 'Symfony\Component\PropertyAccess\PropertyAccess' not found in .../workflow-example/vendor/symfony/workflow/MarkingStore/PropertyAccessorMarkingStore.php on line 37

The reason is the PropertyAccessorMarkingStore (and the ScalarMarkingStore as well)uses PropertyAccess class. So it is basically not possible to use the component without the symfony/property-access.

Is this correct@lyrixx?

@xabbuh
Copy link
Member

👍

Status: Reviewed

@dunglas
Copy link
Member

dunglas commentedSep 5, 2016•
edited
Loading

It's necessary only for default Marking Store implementations. If you use custom implementations, you may not want this package. Asuggest entry would be enough WDYT?

sstok reacted with thumbs up emoji

@OndraM
Copy link
ContributorAuthor

@dunglas Hypothetically, yes, however - as a newcomer who wants to use the component, this is either not the best first impression - you install thesymfony/workflow, implement the Hello world, and it fails on fatal error... And both of the default implementations requires it (so I guess 99% of usages would require it). But I see your point, so the decision whats the best is up to you :).

@dunglas
Copy link
Member

I've no strong opinion about that. It was just some thought. We have basically 2 possibilities:

  1. merge this PR
  2. make it clear in the doc that PropertyInfo must also be installed manually to use the default implementation

@fabpot
Copy link
Member

Thank you@OndraM.

@fabpotfabpot merged commit5957412 intosymfony:masterSep 5, 2016
fabpot added a commit that referenced this pull requestSep 5, 2016
This PR was merged into the 3.2-dev branch.Discussion----------[Workflow] Make PropertyAccess required dependency| Q             | A| ------------- | ---| Branch?       | master (3.2 is not yet released)| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | N/A| Fixed tickets | N/A| License       | MIT| Doc PR        | N/AHi, when using Workflow as a standalone component (and instantiating new `Workflow()` instance), I'm getting errors like:```PHP Fatal error:  Class 'Symfony\Component\PropertyAccess\PropertyAccess' not found in .../workflow-example/vendor/symfony/workflow/MarkingStore/PropertyAccessorMarkingStore.php on line 37```The reason is the PropertyAccessorMarkingStore (and the ScalarMarkingStore as well) [uses](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Workflow/MarkingStore/PropertyAccessorMarkingStore.php#L14) PropertyAccess class. So it is basically not possible to use the component without the symfony/property-access.Is this correct@lyrixx?Commits-------5957412 [Workflow] Make PropertyAccess required dependency
@fabpotfabpot mentioned this pull requestOct 27, 2016
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@OndraM@xabbuh@dunglas@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp