NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[HttpKernel][EventDispatcher] Wrap some log contexts with ClassStub#19829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

nicolas-grekas wants to merge1 commit intosymfony:masterfromnicolas-grekas:profiler-context

Closed

[HttpKernel][EventDispatcher] Wrap some log contexts with ClassStub#19829

nicolas-grekas wants to merge1 commit intosymfony:masterfromnicolas-grekas:profiler-context

Conversation

Copy link

Member

nicolas-grekas commentedSep 2, 2016•
edited
Loading

Q	A
Branch?	master
New feature?	yes
Tests pass?	yes
License	MIT

This PR will be useful when#19614 will be merged to get more detailed log contexts in the "Logs" profiler panel.

This screenshot has been taken with both branches checked out at the same time:

SinceClassStub implements__toString, contexts are logged as e.g.request.INFO: Matched route "{route}". {"route":"app_lucky_number","route_parameters":{"_controller": "[object] (Symfony\\Component\\VarDumper\\Caster\\ClassStub: AppBundle\\Controller\\LuckyController::numberAction)","_route": "app_lucky_number"},"request_uri":"http://127.0.0.1:8000/lucky/number","method":"GET"} [] by Monolog's NormalizerFormatter.

Seldaek/monolog#843 or some variant of it should fix this back to a plain string.