Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[VarDumper] Add LinkStub to create links in HTML dumps#19816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromnicolas-grekas:dump-link-stub
Sep 1, 2016

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?master
New feature?yes
Tests pass?yes
LicenseMIT

This builds on top of#19797 & adds a newLinkStub to inform HtmlDumper about values that can be dumped as html links.

capture du 2016-09-01 16-37-56

Note in the screenshot:

  • the "file" item has ellipsis,
  • the browser displays the target at the bottom

@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commit2b5d642 intosymfony:masterSep 1, 2016
fabpot added a commit that referenced this pull requestSep 1, 2016
… (nicolas-grekas)This PR was merged into the 3.2-dev branch.Discussion----------[VarDumper] Add LinkStub to create links in HTML dumps| Q             | A| ------------- | ---| Branch?       | master| New feature?  | yes| Tests pass?   | yes| License       | MITThis builds on top of#19797 & adds a new `LinkStub` to inform HtmlDumper about values that can be dumped as html links.![capture du 2016-09-01 16-37-56](https://cloud.githubusercontent.com/assets/243674/18171810/8a786518-7063-11e6-9719-1eca295087e7.png)Note in the screenshot:- the "file" item has ellipsis,- the browser displays the target at the bottomCommits-------2b5d642 [VarDumper] Add LinkStub to create links in HTML dumps
@nicolas-grekasnicolas-grekas deleted the dump-link-stub branchSeptember 1, 2016 19:10
@flip111
Copy link
Contributor

@nicolas-grekas how can you choose the link assubl:// ?

@nicolas-grekas
Copy link
MemberAuthor

You give the template to HtmlDumper, e.g.:
$dumper->setDisplayOptions(array('fileLinkFormat' => 'subl://%f:%l'));

Will be done by default once#19807 is merged for Symfony Standard Edition users.

@flip111
Copy link
Contributor

I like Sublime Text, but why make this editor the default ?

@nicolas-grekas
Copy link
MemberAuthor

Where is it the default?

@flip111
Copy link
Contributor

Where? I thought you were just saying it was to become the default ... o_O

@nicolas-grekas
Copy link
MemberAuthor

I inlined thesubl://... string because you asked specifically for sublime :)
In the linked PR, we use thekernel.file_link_format parameter, which has no default value.

@flip111
Copy link
Contributor

Oh that's nice :)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nicolas-grekas@fabpot@flip111
[8]ページ先頭
©2009-2025 Movatter.jp