Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WebProfilerBundle] Make the IP address in the profiler header clickable#19815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@jameshalsall
Copy link
Contributor

@jameshalsalljameshalsall commentedSep 1, 2016
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
LicenseMIT

@fabpot
Copy link
Member

I know that we already had some discussion about this topic. ping@javiereguiluz

@xabbuh
Copy link
Member

What is the actual use case for this change?

@jameshalsall
Copy link
ContributorAuthor

This is to make it easier to jump to results for the current IP, which brings it inline with the behaviour of clicking on the URL.

@xabbuh
Copy link
Member

Let's answer two questions: How common is it that you have profiles with different IP addresses which would justify a need for this feature? And would it be confusing for all other users that the IP address is clickable?

@jameshalsall
Copy link
ContributorAuthor

  1. Quite, if you're viewing the debug profiler in a non-local environment which a lot of people seem to do
  2. I'm not sure it would be confusing given that it's styled exactly the same as the URL in the same part of the profiler.

@javiereguiluz
Copy link
Member

👍 I like this proposal because it changes nothing for most users and it improves the productivity of those using this.

@jameshalsall I'd like to have a minor change before merge: let's make the new link look like the previous text. In line 494 of profiler.css.twig, please update the selector to this:

#summarydl.metadata,#summarydl.metadataa {/*  <-- add this line  */margin:5px00;color:rgba(255,255,255,0.75);}

@jameshalsalljameshalsallforce-pushed theclickable-ip-profiler-layout branch frombd45598 to52606a1CompareNovember 9, 2016 21:52
@jameshalsall
Copy link
ContributorAuthor

This has now been updated.

@fabpotfabpot modified the milestones:3.3,3.2Nov 16, 2016
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@fabpot
Copy link
Member

Thank you@jameshalsall.

@fabpotfabpot merged commit52606a1 intosymfony:masterFeb 14, 2017
fabpot added a commit that referenced this pull requestFeb 14, 2017
…r header clickable (jameshalsall)This PR was merged into the 3.3-dev branch.Discussion----------[WebProfilerBundle] Make the IP address in the profiler header clickable| Q | A || --- | --- || Branch? | master || Bug fix? | no || New feature? | yes || BC breaks? | no || Deprecations? | no || Tests pass? | yes || License | MIT |Commits-------52606a1 [WebProfilerBundle] Make the IP address in the profiler header clickable to view requests by IP
@nicolas-grekasnicolas-grekas modified the milestones:3.x,3.3Mar 24, 2017
@fabpotfabpot mentioned this pull requestMay 1, 2017
ostrolucky pushed a commit to ostrolucky/symfony that referenced this pull requestMar 25, 2018
…profiler header clickable (jameshalsall)This PR was merged into the 3.3-dev branch.Discussion----------[WebProfilerBundle] Make the IP address in the profiler header clickable| Q | A || --- | --- || Branch? | master || Bug fix? | no || New feature? | yes || BC breaks? | no || Deprecations? | no || Tests pass? | yes || License | MIT |Commits-------52606a1 [WebProfilerBundle] Make the IP address in the profiler header clickable to view requests by IP
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

6 participants

@jameshalsall@fabpot@xabbuh@javiereguiluz@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp