Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[WebProfilerBundle] Fix margin on toolbar route panel when no route is found in the request#19812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@jameshalsall
Copy link
Contributor

@jameshalsalljameshalsall commentedSep 1, 2016•
edited
Loading

QA
Branch?3.1
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#19805
LicenseMIT

Just to clarify, this bug was introduced in the 3.1 release when some of the toolbar was re-structured

@javiereguiluz
Copy link
Member

javiereguiluz commentedSep 1, 2016•
edited
Loading

This makes the redirection/forward icon to be closer to the status panel than before ... but it's probably OK:

BeforeAfter
beforeafter
jameshalsall reacted with thumbs up emoji

@jameshalsalljameshalsall changed the titleFix margin on toolbar route panel when no route is found in the request[Profiler] Fix margin on toolbar route panel when no route is found in the requestSep 1, 2016
@jameshalsall
Copy link
ContributorAuthor

Maybe the better solution is to wrap up the optionally displayed SVG and the other elements representing the route in a single element that has themargin-left?

@javiereguiluz
Copy link
Member

We're always cautious about modifying the HTML structure ... so maybe the following would suffice:

.sf-toolbar-block-request .sf-toolbar-status+svg {margin-left:5px;}

@jameshalsalljameshalsall changed the title[Profiler] Fix margin on toolbar route panel when no route is found in the request[WebProfilerBundle] Fix margin on toolbar route panel when no route is found in the requestSep 1, 2016
When no route was found (404) then the route panel margin would causeunnecessary space between the status panel and the response time panel.
@jameshalsalljameshalsallforce-pushed theright-margin-toolbar-route-panel branch frombe08d76 to7fdffd1CompareSeptember 1, 2016 13:32
@jameshalsall
Copy link
ContributorAuthor

Updated, that fixes both scenarios :)

@fabpot
Copy link
Member

Thank you@jameshalsall.

@fabpotfabpot merged commit7fdffd1 intosymfony:3.1Sep 1, 2016
fabpot added a commit that referenced this pull requestSep 1, 2016
… no route is found in the request (jameshalsall)This PR was merged into the 3.1 branch.Discussion----------[WebProfilerBundle] Fix margin on toolbar route panel when no route is found in the request| Q             | A| ------------- | ---| Branch?       | 3.1| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#19805| License       | MITJust to clarify, this bug was introduced in the 3.1 release when some of the toolbar was re-structuredCommits-------7fdffd1 [WebProfilerBundle] Fix margin on toolbar route panel.
@fabpotfabpot mentioned this pull requestSep 3, 2016
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jameshalsall@javiereguiluz@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp