Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Add %debug.file_link_format% with remapping for IDE links#19807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| ; | ||
| $container->getDefinition('var_dumper.html_dumper') | ||
| ->replaceArgument(2, AbstractDumper::DUMP_LIGHT_ARRAY) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This one and the previous one should probably oneliners.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I removed this completely: not related and not a good idea anyway
8972e86 to0655c9bComparenicolas-grekas commentedSep 1, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
PR is ready, failure unrelated (composer bug). E.g. |
80afcf9 toa258e7eComparefabpot commentedSep 1, 2016
Can you make a PR to update the docs? |
nicolas-grekas commentedSep 1, 2016
doc PR added |
| <tagname="data_collector"id="dump"template="@Debug/Profiler/dump.html.twig"priority="240" /> | ||
| <argumenttype="service"id="debug.stopwatch"on-invalid="ignore" /> | ||
| <argument>null</argument><!-- %templating.helper.code.file_link_format%--> | ||
| <argument>%kernel.file_link_format%</argument> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't like the fact that this is now "global". We don't have that many globalkernel.* arguments and this one does not feel like it should be one of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is it just a naming issue or the fact that it is always defined (which saves boilerplate in 4 bundles but can be removed)? Any suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
parameter renamed todebug.file_link_format
| $this->container->setParameter('kernel.debug',false); | ||
| $this->container->setParameter('kernel.root_dir',__DIR__); | ||
| $this->container->setParameter('kernel.charset','UTF-8'); | ||
| $this->container->setParameter('kernel.file_link_format',null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should be renamed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fixed
fabpot commentedSep 14, 2016
Thank you@nicolas-grekas. |
…mapping for IDE links (nicolas-grekas)This PR was merged into the 3.2-dev branch.Discussion----------[FrameworkBundle] Add %debug.file_link_format% with remapping for IDE links| Q | A| ------------- | ---| Branch? | master| New feature? | yes| Tests pass? | yes| Fixed tickets |#14340| License | MIT| Doc PR |symfony/symfony-docs#6944`templating.helper.code.file_link_format` is a parameter that requires templating to be defined, but holds a concept that is used beyond templating borders.Let's make it a general parameter that can be injected easily when required.Commits-------1c4ca8c [FrameworkBundle] Add %debug.file_link_format% with remapping for IDE links
…() instead of parse_str() (nicolas-grekas)This PR was merged into the 3.2-dev branch.Discussion----------[FrameworkBundle] Parse source link maps using json_decode() instead of parse_str()| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | updated code exists only on master| Deprecations? | no| Tests pass? | yes| Fixed tickets |#19807| License | MIT| Doc PR |symfony/symfony-docs#6944Because `parse_str()` turns some characters into underscores in keys (e.g. `.`).Commits-------9b174fb [FrameworkBundle] Parse source link maps using json_decode() instead of parse_str()
This PR was merged into the master branch.Discussion----------Update doc about IDE file link formattodo:- [x] ~~tell about `kernel.file_link_format` parameter?~~- [x] tell about prefix maps (seesymfony/symfony#19807)Commits-------f744396 Update doc about IDE file link format
…with remapping for IDE links (nicolas-grekas)This PR was merged into the 3.2-dev branch.Discussion----------[FrameworkBundle] Add %debug.file_link_format% with remapping for IDE links| Q | A| ------------- | ---| Branch? | master| New feature? | yes| Tests pass? | yes| Fixed tickets |symfony#14340| License | MIT| Doc PR |symfony/symfony-docs#6944`templating.helper.code.file_link_format` is a parameter that requires templating to be defined, but holds a concept that is used beyond templating borders.Let's make it a general parameter that can be injected easily when required.Commits-------1c4ca8c [FrameworkBundle] Add %debug.file_link_format% with remapping for IDE links
Uh oh!
There was an error while loading.Please reload this page.
templating.helper.code.file_link_formatis a parameter that requires templating to be defined, but holds a concept that is used beyond templating borders.Let's make it a general parameter that can be injected easily when required.