Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Incorrect line break in exception message (500 debug page)#19780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
pedroresende commentedAug 29, 2016
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | 19041 |
| License | MIT |
| font-size:20px; | ||
| color:#313131; | ||
| word-break:break-all; | ||
| word-break:keep-all; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
wouldn't it be better to useword-wrap: break-word here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@nicolas-bastien You're right, already updated to break-word and rebased the PR
c733790 tod1cde23Compare| font-size:20px; | ||
| color:#313131; | ||
| word-break: break-all; | ||
| word-break: break-word; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should beword-wrap: break-word:break-word is an unofficial value forword-break.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
d1cde23 tof51069bComparefabpot commentedSep 6, 2016
Thank you@pedroresende. |
…e (500 debug page) (pedroresende)This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes#19780).Discussion----------[FrameworkBundle] Incorrect line break in exception message (500 debug page)| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | [19041](#19041)| License | MITCommits-------1393e3e [FrameworkBundle] Fix Incorrect line break in exception message (500 debug page)
pedroresende commentedSep 7, 2016
@fabpot Sure thing, always glad to help a wonderful project. Btw any special reason for not being added to the list of contributors ? |
jakzal commentedSep 8, 2016
@pedroresende that list is refreshed periodically. You'll eventually get there :) |