Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Yaml] sync test and actually triggered message#19766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedAug 28, 2016
| Q | A |
|---|---|
| Branch? | 3.1 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | see failures in#19757 |
| License | MIT |
| Doc PR |
HeahDude commentedAug 28, 2016
👍 Status: reviewed |
javiereguiluz commentedAug 29, 2016
👍 |
| publicfunctiontestParseUnquotedScalarStartingWithPercentCharacter() | ||
| { | ||
| ErrorAssert::assertDeprecationsAreTriggered('Not quotinga scalar starting with the "%" indicator character is deprecated since Symfony 3.1 and will throw a ParseException in 4.0.',function () { | ||
| ErrorAssert::assertDeprecationsAreTriggered('Not quotingthe scalar "%foo " starting with the "%" indicator character is deprecated since Symfony 3.1 and will throw a ParseException in 4.0.',function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@xabbuh is the trailing space legitimate or is it another bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
imo it's legitimate, it's what the parser receives at that stage
nicolas-grekas commentedAug 29, 2016
Thank you@xabbuh. |
This PR was merged into the 3.1 branch.Discussion----------[Yaml] sync test and actually triggered message| Q | A| ------------- | ---| Branch? | 3.1| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | see failures in#19757| License | MIT| Doc PR |Commits-------e8dfd4d [Yaml] sync test and actually triggered message