Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PhpUnitBridge] allow to pass a message as string#19757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@xabbuh
Copy link
Member

QA
Branch?master
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

Currently our tests for deprecation messages just pass "accidentally" (we never pass arrays but only strings).

ogizanagi reacted with thumbs up emoji
@HeahDude
Copy link
Contributor

👍

Status: reviewed

@chalasr
Copy link
Member

chalasr commentedAug 27, 2016•
edited
Loading

Tests are failing on travis due to an outdated assertion, unrelated to these changes.
See#19760

👍

@xabbuh
Copy link
MemberAuthor

@chalasr Thanks for the fix. Actually, the tests should have failed before, but didn't because of the implementation inside theErrorAssert that will be fixed by this PR.

chalasr and ogizanagi reacted with thumbs up emoji

@javiereguiluz
Copy link
Member

👍

nicolas-grekas added a commit that referenced this pull requestAug 29, 2016
This PR was merged into the 3.1 branch.Discussion----------[Yaml] sync test and actually triggered message| Q             | A| ------------- | ---| Branch?       | 3.1| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | see failures in#19757| License       | MIT| Doc PR        |Commits-------e8dfd4d [Yaml] sync test and actually triggered message
@nicolas-grekas
Copy link
Member

Thank you@xabbuh.

@nicolas-grekasnicolas-grekas merged commit8ceed79 intosymfony:masterAug 29, 2016
nicolas-grekas added a commit that referenced this pull requestAug 29, 2016
This PR was merged into the 3.2-dev branch.Discussion----------[PhpUnitBridge] allow to pass a message as string| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |Currently our tests for deprecation messages just pass "accidentally" (we never pass arrays but only strings).Commits-------8ceed79 [PhpUnitBridge] allow to pass a message as string
@xabbuhxabbuh deleted the error-assert-expected-messages-type branchAugust 29, 2016 10:31
@fabpotfabpot mentioned this pull requestOct 27, 2016
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xabbuh@HeahDude@chalasr@javiereguiluz@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp