Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fixes the calendar in constructor to handle null#19751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:2.7fromwakqasahmed:2.7
Aug 27, 2016

Conversation

@wakqasahmed
Copy link
Contributor

@wakqasahmedwakqasahmed commentedAug 26, 2016•
edited
Loading

QA
Branch?2.7
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#19688
LicenseMIT
Doc PRnone

Fix the calendar exception to handle null, error was raised while exporting from akeneo

The Symfony\Component\Intl\DateFormatter\IntlDateFormatter::__construct() method's argument $calendar value NULL behavior is not implemented. Only the GREGORIAN calendar is supported. Please install the "intl" extension for full localization capabilities.

https://cloud.githubusercontent.com/assets/4486133/17287404/81f951cc-57e0-11e6-9f6f-e231bbf00bf4.png

@wakqasahmed
Copy link
ContributorAuthor

wakqasahmed commentedAug 26, 2016•
edited
Loading

@nicolas-grekas

Test Details:

BEFORE
————
$ php ./phpunit --filter testConstructorWithoutCalendar IntlDateFormatterTest src/Symfony/Component/Intl/Tests/DateFormatter/IntlDateFormatterTest.php
PHPUnit 5.1.7 by Sebastian Bergmann and contributors.

Testing Symfony\Component\Intl\Tests\DateFormatter\IntlDateFormatterTest
E 1 / 1 (100%)

Time: 49 ms, Memory: 4.50MB

There was 1 error:

  1. Symfony\Component\Intl\Tests\DateFormatter\IntlDateFormatterTest::testConstructorWithoutCalendar
    Symfony\Component\Intl\Exception\MethodArgumentValueNotImplementedException: The Symfony\Component\Intl\DateFormatter\IntlDateFormatter::__construct() method's argument $calendar value NULL behavior is not implemented. Only the GREGORIAN calendar is supported. Please install the "intl" extension for full localization capabilities.

/Users/waqasahmed/Desktop/symfony-2.7/src/Symfony/Component/Intl/DateFormatter/IntlDateFormatter.php:153
/Users/waqasahmed/Desktop/symfony-2.7/src/Symfony/Component/Intl/Tests/DateFormatter/IntlDateFormatterTest.php:33

FAILURES!
Tests: 1, Assertions: 0, Errors: 1.
KO src/Symfony/Component/Intl/Tests/DateFormatter/IntlDateFormatterTest.php

AFTER
———

$ php ./phpunit --filter testConstructorWithoutCalendar IntlDateFormatterTest src/Symfony/Component/Intl/Tests/DateFormatter/IntlDateFormatterTest.php
PHPUnit 5.1.7 by Sebastian Bergmann and contributors.

Testing Symfony\Component\Intl\Tests\DateFormatter\IntlDateFormatterTest
. 1 / 1 (100%)

Time: 45 ms, Memory: 4.25MB

OK (1 test, 1 assertion)
OK src/Symfony/Component/Intl/Tests/DateFormatter/IntlDateFormatterTest.php

@Tobion
Copy link
Contributor

LGTM 👍 as it's in line withhttp://php.net/manual/en/intldateformatter.create.php

@HeahDude
Copy link
Contributor

👍

Status: reviewed

@fabpot
Copy link
Member

Thank you@wakqasahmed.

@fabpotfabpot merged commit43f2672 intosymfony:2.7Aug 27, 2016
fabpot added a commit that referenced this pull requestAug 27, 2016
…med)This PR was merged into the 2.7 branch.Discussion----------Fixes the calendar in constructor to handle null| Q             | A| ------------- | ---| Branch?       | 2.7| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#19688| License       | MIT| Doc PR        | noneFix the calendar exception to handle null, error was raised while exporting from akeneoThe Symfony\Component\Intl\DateFormatter\IntlDateFormatter::__construct() method's argument $calendar value NULL behavior is not implemented. Only the GREGORIAN calendar is supported. Please install the "intl" extension for full localization capabilities.https://cloud.githubusercontent.com/assets/4486133/17287404/81f951cc-57e0-11e6-9f6f-e231bbf00bf4.pngCommits-------43f2672 Fixes the calendar in constructor to handle null
This was referencedSep 2, 2016
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wakqasahmed@Tobion@HeahDude@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp