Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Validator] Added context object method callback to choice validator#19745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@Bouwdie
Copy link

QA
Branch?"master"
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

patrick-mcdougle reacted with thumbs up emojipatrick-mcdougle reacted with hooray emojipatrick-mcdougle reacted with heart emoji
@BouwdieBouwdieforce-pushed thechoice-validator-callable branch fromdc39bc9 toc62d94cCompareAugust 26, 2016 12:12
@Bouwdie
Copy link
Author

Could the build please be restarted? I squashed a commit on the fork branch.

@jakzal
Copy link
Contributor

jakzal commentedAug 26, 2016•
edited
Loading

@Bouwdie the build is triggered automatically on push. I restarted it nevertheless.

Thefailure is legitimate (it's introduced by this PR).

@Bouwdie
Copy link
Author

Bouwdie commentedAug 26, 2016•
edited
Loading

@jakzal thx for restarting them anyway! I should have taken the behaviour of is_callable into account.
https://3v4l.org/j8CBb. The test opened something up that already occurred if a non-static method was given as callback.

…validator to prevent invoking non-static methods
@Bouwdie
Copy link
Author

@jakzal Everything is working correctly and the build succeeds. Is there anything more i can do to speed the review process?

@fghirlanda
Copy link

👍

1 similar comment
@proggeler
Copy link

👍

@fabpot
Copy link
Member

Thank you@Bouwdie.

Bouwdie reacted with thumbs up emoji

@patrick-mcdougle
Copy link
Contributor

Documenting this feature here:symfony/symfony-docs#6973

@Bouwdie
Copy link
Author

@ro0NL Thank you for noticing this pull request 👍

@BouwdieBouwdie deleted the choice-validator-callable branchSeptember 18, 2016 15:11
xabbuh added a commit to symfony/symfony-docs that referenced this pull requestSep 21, 2016
This PR was squashed before being merged into the master branch (closes#6973).Discussion----------Callback doesn't have to be staticAdding documentation forsymfony/symfony#19745Commits-------79bc283 Callback doesn't have to be static
@fabpotfabpot mentioned this pull requestOct 27, 2016
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Bouwdie@jakzal@fghirlanda@proggeler@fabpot@patrick-mcdougle@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp