New features should be submitted on master (but no need to close this PR: you can either rebase then change the base branch yourself in the github UI, or we can do it while merging).

Btw, shouldn't we deprecateParserCacheInterface in favor ofPsr\Cache\CacheItemPoolInterface?

tests are missing btw

@nicolas-grekas you're right we should deprecateParserCacheInterface in favor ofPsr\Cache\CacheItemPoolInterface.

But what does this involve in EL component ?

I can add@deprecated tag onParserCacheInterface ? And then, how to stop use ofParserCacheInterface in ExpressionLanguage without creating BC break ? I mean, changing type hint on ExpressionLanguage::__construct is not conceivable, right ?

This is my first PR tentative, so be indulgent ^^ hope my questions are not too boring

add@deprecated tag on ParserCacheInterface

yes

changing type hint on ExpressionLanguage::__construct

yes! by removing the type hint (not replacing it with CacheItemPoolInterface), then doing dynamic checks in the constructor and triggering a deprecation when required

Thanks for your help@nicolas-grekas.
I've made some changes in order to make cache PSR6 compliant, using adapter pattern.

I have a few other questions :

• I useSymfony\Component\Cache\Adapter\ArrayAdapter by default inExpressionLanguage.php. Is it a bad thing to hard coupling with Cache component ? Perhaps it's better to use the existingArrayParserCache with the adapter.
• With PSR6 specifications, some characters are forbidden in keys declarations. For now my sanitize method is not sufficient, but I don't know exactly how to assure unique keys with expressions. Replacing with a hash ?

👍

Could someone explain me why in the last buildPHP:7 deph=high, I have 54 errors inSymfony\Bundle\SecurityBundle\Tests\Functional ?

Here is the exception thrown all the time :
Symfony\Component\DependencyInjection\Exception\LogicException: Asset support cannot be enabled as the Asset component is not installed.

@ReDnAxE Should be fixed now

@stof with a@trigger_error inParserCache\ParserCacheInterface.php as you asked,PHP:7 deph=high was broken as explained above, I could not explain why.
@fabpot Builds are ok.

I thinkwe should try harder following@stof's advice. The tests don't decide.

@nicolas-grekas I agree... This is why I prefer to mention him

Can you add the trigger again so that we can see what's failing in the tests?

@nicolas-grekas Why not ! I re-push the@trigger_error.
I confess I do not understand. Now, it's no more the same errors : we have fails in PHP7 dep=high|low inTwigBundle Test Suite

With the sameSymfony\Component\DependencyInjection\Exception\LogicException exception type thrown as before

Not related I guess

I rebased my branch to533c11c (master)
I will rebase one more time

I rebased on418944b
same errors... uh no, worst, 1 error in appVeyor o_O :
Symfony\Component\HttpKernel\Tests\ClientTest::testGetScript RuntimeException: OUTPUT: ERROR OUTPUT:

I know we are in 1 october, so it's probably too late ^^, but I saw master is not stable on the last418944b commit. Perhaps I would rebase on a older stable master commit ?

EDIT: I'm onc2d8356 now. Appveyor recovered..! good night ;)

@nicolas-grekas it works better when rebasing on master's clean commit ;)
I changed deprecation notices versions from "3.2" to "3.3"

Please also add the deprecation in the upgrade files.

I changed deprecation notices versions from "3.2" to "3.3"

why that? that could still happen for 3.2 , who knows :)
also please add a note in the upgrade files as suggested by@xabbuh

Indeed, I'd like to include that in 3.2 if possible.

👍 from me after the remaining comments have been addressed

Thank's ! I'll make thoses changes this afternoon :) I learned that features was freezed for 3.2. This is why I changed to 3.3

The changes are done.

ping@nicolas-grekas ;)

Thank you@ReDnAxE.