Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle][Security] Remove useless mocks#19736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:2.7fromGuilhemN:MOCK
Aug 25, 2016

Conversation

@GuilhemN
Copy link
Contributor

QA
Branch?2.7
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

Removes mocks causing issues in#19734.

@nicolas-grekas
Copy link
Member

👍
Status: reviewed

@fabpot
Copy link
Member

Thank you @Ener-Getick.

@fabpotfabpot merged commitfcd3345 intosymfony:2.7Aug 25, 2016
fabpot added a commit that referenced this pull requestAug 25, 2016
…etick)This PR was merged into the 2.7 branch.Discussion----------[FrameworkBundle][Security] Remove useless mocks| Q             | A| ------------- | ---| Branch?       | 2.7| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |Removes mocks causing issues in#19734.Commits-------fcd3345 [FrameworkBundle][Security] Remove useless mocks
@GuilhemNGuilhemN deleted the MOCK branchAugust 25, 2016 17:54
@GuilhemN
Copy link
ContributorAuthor

@fabpot Thanks to you !

BTW shouldn't your tool merging PRs use a more generic reference such assymfony/symfony#19736 ?
Becausereferences are broken in commits title of sub repositories.

@fabpot
Copy link
Member

That's a good remark. But I'm afraid that adding symfony/symfony in front would make the message way less readable :(

@GuilhemN
Copy link
ContributorAuthor

GuilhemN commentedAug 25, 2016
edited
Loading

@fabpot if i'm not wrong github is smart enough to hide it when that's not necessary (in the main repo).

Edit: i think that's worth it, i often want to read comments corresponding to a change and having a link is a time saver :)

@fabpot
Copy link
Member

probably, but I was more talking about git in general, like when doing git log, ...

@GuilhemN
Copy link
ContributorAuthor

That's a good argument :/
maybe you could update references in splitter to make them longer only in sub repos ? Otherwise that's still just a small detail, convenient but it shouldn't make other things harder of course.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GuilhemN@nicolas-grekas@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp