Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle][Security] Remove useless mocks#19736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedAug 25, 2016
👍 |
fabpot commentedAug 25, 2016
Thank you @Ener-Getick. |
…etick)This PR was merged into the 2.7 branch.Discussion----------[FrameworkBundle][Security] Remove useless mocks| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |Removes mocks causing issues in#19734.Commits-------fcd3345 [FrameworkBundle][Security] Remove useless mocks
GuilhemN commentedAug 25, 2016
@fabpot Thanks to you ! BTW shouldn't your tool merging PRs use a more generic reference such as |
fabpot commentedAug 25, 2016
That's a good remark. But I'm afraid that adding symfony/symfony in front would make the message way less readable :( |
GuilhemN commentedAug 25, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@fabpot if i'm not wrong github is smart enough to hide it when that's not necessary (in the main repo). Edit: i think that's worth it, i often want to read comments corresponding to a change and having a link is a time saver :) |
fabpot commentedAug 25, 2016
probably, but I was more talking about git in general, like when doing git log, ... |
GuilhemN commentedAug 25, 2016
That's a good argument :/ |
Removes mocks causing issues in#19734.