NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Fix EntityType->empty_data=null#19732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

pierre-H wants to merge1 commit intosymfony:masterfrompierre-H:patch-1

Closed

Fix EntityType->empty_data=null#19732

pierre-H wants to merge1 commit intosymfony:masterfrompierre-H:patch-1

Conversation

Copy link

pierre-H commentedAug 25, 2016

Q	A
Branch?	"master"
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
License	MIT

Symfony 3.1, Doctine 2.5, PHP 7, SQL Server

With :

$builder            ->add('users', EntityType::class, array(                'label' => 'Users',                'class' => 'AppBundle\Entity\Users',                'choice_label' => 'name',                'query_builder' => function (EntityRepository $er) {                    return $er->createQueryBuilder('u')                        ->orderBy('u.name', 'ASC');                },                'empty_data'  => null,                'required' => false            ))

I got an error :
SQLSTATE [42000, 8114]: [Microsoft][ODBC Driver 13 for SQL Server][SQL Server]Eror converting nvarchar datatype to numeric.

Fix EntityType->empty_data=null

002e20b

Symfony 3.1, Doctine 2.5, PHP 7, SQL ServerWith :```$builder            ->add('users', EntityType::class, array(                'label' => 'Users',                'class' => 'AppBundle\Entity\Users',                'choice_label' => 'name',                'query_builder' => function (EntityRepository $er) {                    return $er->createQueryBuilder('u')                        ->orderBy('u.name', 'ASC');                },                'empty_data'  => null,                'required' => false            ))```I got an error : SQLSTATE [42000, 8114]: [Microsoft][ODBC Driver 13 for SQL Server][SQL Server]Eror converting nvarchar datatype to numeric.

carsonbot added Status: Needs Review Bug labels

Aug 25, 2016

lemoinem approved these changes

Sep 28, 2016

View reviewed changes

Copy link

Contributor

lemoinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Status: Reviewed

lemoinem suggested changes

Sep 28, 2016

View reviewed changes

Copy link

Contributor

lemoinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi, Sorry, I've been too fast the first time.

Thank you for the contribution.

Could you add a test to make sure the bug doesn't reappears?

Plus, if you could include the whole PR template please, each part is important. If you think one is not relevant for your PR, please leave it empty or fill it with N/A instead of removing the line entirely.

Thank you!

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Sep 28, 2016

Copy link

Contributor

HeahDude commentedSep 28, 2016

This fix is wrong. Ifmultiple option isfalse theempty_data should be an empty string notnull sincenullat this step won't be transformed properly. The docs will be fixed withsymfony/symfony-docs#6265.