Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Yaml] improve changelog and upgrade entries#19731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| * Support for silently ignoring duplicate keys in YAML has been deprecated and | ||
| will lead to a`ParseException` in Symfony 4.0. | ||
| * Mappings with a colon (`:`) that is not followed by a whitespace are deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't think you are talking about the same thing than before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
actually you just removed the wrong entry (see the following one)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oh indeed, good catch. Thank you for the heads up.
HeahDude commentedAug 27, 2016
👍 Status: reviewed |
fabpot commentedAug 27, 2016
Thank you@xabbuh. |
This PR was merged into the 3.2-dev branch.Discussion----------[Yaml] improve changelog and upgrade entries| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? |no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |Improves the wording as suggested by@javiereguiluz in#19538 (comment).Commits-------e288256 [Yaml] improve changelog and upgrade entries
Improves the wording as suggested by@javiereguiluz in#19538 (comment).