Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] Allow getting synthetic before compilation#19715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @trigger_error(sprintf('Calling %s() before compiling the container is deprecated for non-synthetic services since version 3.2 and will throw an exception in 4.0.',__METHOD__),E_USER_DEPRECATED); | ||
| } | ||
| if (null ===$definition) { | ||
| return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Considerable.
nicolas-grekas commentedSep 6, 2016
As far as I understand correctly, this is targeting the use case of fetching services while the container is being build. Does anyone really do this already? |
fabpot commentedSep 6, 2016
... which nobody should do anyway. Phase one is describing the container, phase 2 is building/compiling, phase 3 is using. |
ro0NL commentedSep 7, 2016
👍 i considered it more from a convenience pov. But im fine if this is locked by design. |
Uh oh!
There was an error while loading.Please reload this page.
Same as#19619 but i messed up git. So here's a clean PR.
After#19673