Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[DI] Exclude privates from getServiceIds#19707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
ro0NL wants to merge1 commit intosymfony:masterfromro0NL:di/exclude-privates
Closed

[DI] Exclude privates from getServiceIds#19707

ro0NL wants to merge1 commit intosymfony:masterfromro0NL:di/exclude-privates

Conversation

@ro0NL
Copy link
Contributor

@ro0NLro0NL commentedAug 22, 2016
edited
Loading

QA
Branch?"master"
Bug fix?yes?
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketscomma-separated list of tickets fixed by the PR, if any
LicenseMIT
Doc PRreference to the documentation PR, if any

I guess this should happen by design:getServiceIds gives a list of ids allowed toget.

Conflicts with:#19690

@stof
Copy link
Member

Note that a ContainerBuilder will still return the ids of private services (as it contains a definition for it). But this is fine IMO. During the building phase, dealing with private services is expected too.

ogizanagi reacted with thumbs up emoji

@ro0NL
Copy link
ContributorAuthor

ro0NL commentedAug 22, 2016
edited
Loading

Good point.. i think its negligible indeed. I hope, with#19683, todeprecate the whole$this->privates thingy anyway.

@nicolas-grekas
Copy link
Member

So, do we consider this a bc break or not?

@ro0NL
Copy link
ContributorAuthor

Im reconsidering this. It makes sense to letgetServiceIds return all available service ids (implied by naming), which currently still includes privates by design.

Ie. i think the problem is different, by in general having to deal with privates in a container.

In 4.x when getting privates will throw a exception, they can be excluded fromhas,getServiceIds, etc. However, to throw, we must still track privates (that is why i like randomizing better, as it completely rules out privates from a container.

@ro0NLro0NL closed thisAug 22, 2016
@ro0NLro0NL deleted the di/exclude-privates branchAugust 23, 2016 10:59
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ro0NL@stof@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp