Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] Exclude privates from getServiceIds#19707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
stof commentedAug 22, 2016
Note that a ContainerBuilder will still return the ids of private services (as it contains a definition for it). But this is fine IMO. During the building phase, dealing with private services is expected too. |
ro0NL commentedAug 22, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
nicolas-grekas commentedAug 22, 2016
So, do we consider this a bc break or not? |
ro0NL commentedAug 22, 2016
Im reconsidering this. It makes sense to let Ie. i think the problem is different, by in general having to deal with privates in a container. In 4.x when getting privates will throw a exception, they can be excluded from |
Uh oh!
There was an error while loading.Please reload this page.
I guess this should happen by design:
getServiceIdsgives a list of ids allowed toget.Conflicts with:#19690